From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753078AbbIRJof (ORCPT ); Fri, 18 Sep 2015 05:44:35 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50187 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751992AbbIRJod (ORCPT ); Fri, 18 Sep 2015 05:44:33 -0400 Date: Fri, 18 Sep 2015 11:44:31 +0200 From: Maxime Ripard To: Yassin Jaffer Cc: "linux-sunxi@googlegroups.com" , Dmitry Torokhov , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] input: Add new sun4i-keypad driver Message-ID: <20150918094431.GN4684@lukather> References: <1442325957-10102-1-git-send-email-yassinjaffer@gmail.com> <1442325957-10102-4-git-send-email-yassinjaffer@gmail.com> <20150917130520.GD4684@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="U/fW6JBK3GqE0Htg" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --U/fW6JBK3GqE0Htg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Yassin, On Fri, Sep 18, 2015 at 10:19:55AM +1000, Yassin Jaffer wrote: > Hi Maxime >=20 > I appreciate your time and efforts . >=20 > Do you need that rate to be enforced, or is it some leftover from the > > allwinner BSP? >=20 >=20 > I've found that clock rate works fine with the default denounce and scan > cycle. It was not really my point. My point was do you *need* it to operate. And so your properties were in clock cycles? Please use a unit indenpendant of the clock rate, like seconds or Hz (or any multiple of them). > By the way do you have any dev board which expose the keypad pins? I don't think I have any. Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --U/fW6JBK3GqE0Htg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV+9z/AAoJEBx+YmzsjxAgjXwQAIqBdbuV/WpN8hBxL/3rX57B cmX/XZFyk3q5on++c0jcEaYnsS8Sw+KQxGlCsYQ0OhmTerZq8qwhpBKF8WrrYT/9 ZyPLlEgd/+1vHUtvkzxUvZQNnlhGura5e2JBCIumr3/2jOwkQlzwlOFTeRkE7B0g RpU2WGh98iH8NhcCThdqi+xUEa7qJ7rIo2j/mq4W5r0lD7FP/5Fzv1VBbBj9/jVf IgBY3rFZay5EZMbCLoqSk7HJ+0+0Z5F0wLWDnmVAqAF9cP4bEXtRBmTuF2rrA83A g0p5slfD5ku48yWEJUk6uLkw+YZO/rxy+P9VFQzoV5ZvF2xFpGyW52d3eNc60AID Rx+VP42TnUz+PJl7bZ4e17S8AHJa2eImIBzgppLywih7lw6C/rAF/Yi5ZxJFDHm+ X4NxoHeTeiJ2zeLfSCk/kzwfLcp7FTYxVgrYPufRzxtIa/G2+XHA0Gh/vHEl/dMV Sg2eGgFB3fI9Gr0s/wBt9wyGOVo4cc/iW75G7S9wkNYlt65nRdZCPyr2jpuGcnYt CZgqLo8ZlxEwblvzmyRFzcpA9/AJVwuDUAdJ6ZBTM2doMrI0pK9xChJluhQ/PpOo 1wAhMhlCEGH3WgHwyT7Aoo9I58PyxuQOQKfNcQ+797H1Y7TSnhQK95Q/H1t4sdjG 9Hl5mvbQxWEpZqzd1iY5 =DwnV -----END PGP SIGNATURE----- --U/fW6JBK3GqE0Htg--