From: Stephen Boyd <sboyd@codeaurora.org>
To: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
Cc: Andy Gross <agross@codeaurora.org>,
David Brown <davidb@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Frank Rowand <frank.rowand@sonymobile.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition
Date: Fri, 18 Sep 2015 16:33:16 -0700 [thread overview]
Message-ID: <20150918233316.GB23081@codeaurora.org> (raw)
In-Reply-To: <1442062934-13449-4-git-send-email-ivan.ivanov@linaro.org>
On 09/12, Ivan T. Ivanov wrote:
> Stale Event Enable command should be 5 not 8, fix this.
>
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> ---
> drivers/tty/serial/msm_serial.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/msm_serial.h b/drivers/tty/serial/msm_serial.h
> index 60917d30c6b5..223f961f992a 100644
> --- a/drivers/tty/serial/msm_serial.h
> +++ b/drivers/tty/serial/msm_serial.h
> @@ -59,7 +59,7 @@
> #define UART_CR_CMD_SET_RFR (13 << 4)
> #define UART_CR_CMD_RESET_RFR (14 << 4)
> #define UART_CR_CMD_PROTECTION_EN (16 << 4)
> -#define UART_CR_CMD_STALE_EVENT_ENABLE (80 << 4)
> +#define UART_CR_CMD_STALE_EVENT_ENABLE (5 << 8)
I don't get this one
5 << 8 == 80 << 4
so this makes no difference.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-09-18 23:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-12 13:02 [PATCH 0/7] tty: serial: msm: Add DMA support and fix bit definitions Ivan T. Ivanov
2015-09-12 13:02 ` [PATCH 1/7] tty: serial: msm: Add mask value for UART_DM registers Ivan T. Ivanov
2015-09-12 13:02 ` [PATCH 2/7] tty: serial: msm: replaces (1 << x) with BIT(x) macro Ivan T. Ivanov
2015-09-12 13:02 ` [PATCH 3/7] tty: serial: msm: Fix command Stale Event Enable definition Ivan T. Ivanov
2015-09-18 23:33 ` Stephen Boyd [this message]
2015-09-19 4:56 ` Ivan T. Ivanov
2015-09-12 13:02 ` [PATCH 4/7] tty: serial: msm: Add msm prefix to all driver functions Ivan T. Ivanov
2015-09-18 23:34 ` Stephen Boyd
2015-09-12 13:02 ` [PATCH 5/7] tty: serial: msm: Add TX DMA support Ivan T. Ivanov
2015-09-12 13:02 ` [PATCH 6/7] tty: serial: msm: Add RX " Ivan T. Ivanov
2015-09-12 13:02 ` [PATCH 7/7] tty: serial: msm: Remove 115.2 Kbps maximum baud rate limitation Ivan T. Ivanov
2015-09-24 23:27 ` [PATCH 0/7] tty: serial: msm: Add DMA support and fix bit definitions Srinivas Kandagatla
2015-09-28 7:49 ` Ivan T. Ivanov
2015-09-29 11:51 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918233316.GB23081@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.rowand@sonymobile.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivan.ivanov@linaro.org \
--cc=jslaby@suse.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).