From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754230AbbITQPj (ORCPT ); Sun, 20 Sep 2015 12:15:39 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:56377 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753585AbbITQPi (ORCPT ); Sun, 20 Sep 2015 12:15:38 -0400 Date: Sun, 20 Sep 2015 11:15:28 -0500 From: Felipe Balbi To: Sudip Mukherjee CC: Haavard Skinnemoen , Hans-Christian Egtvedt , Felipe Balbi , Greg Kroah-Hartman , , , Andrew Morton Subject: Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency Message-ID: <20150920161528.GB1447@saruman.tx.rr.com> Reply-To: References: <1442682779-20077-1-git-send-email-sudipm.mukherjee@gmail.com> <1442682779-20077-3-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cmJC7u66zC7hs+87" Content-Disposition: inline In-Reply-To: <1442682779-20077-3-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cmJC7u66zC7hs+87 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 19, 2015 at 10:42:58PM +0530, Sudip Mukherjee wrote: > While building allmodconfig on avr32 the build failed with the error: > "at91_pmc_base" [drivers/usb/gadget/udc/atmel_usba_udc.ko] undefined! >=20 > On checking the code it turned out that if CONFIG_OF is defined then it > is using at91_pmc_read() which is using at91_pmc_base. And unless > COMMON_CLK_AT91 is defined we donot have at91_pmc_base. And > COMMON_CLK_AT91 is available with AT91 architecture. > Mention the dependency such that this driver builds with avr32 only if > OF is not enabled. >=20 > Signed-off-by: Sudip Mukherjee > --- >=20 > Tested build with at91_dt_defconfig and allmodconfig of avr32. Build log > at: > https://travis-ci.org/sudipm-mukherjee/parport/builds/81168845 >=20 > drivers/usb/gadget/udc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kcon= fig > index 9a3a6b0..cdbff54 100644 > --- a/drivers/usb/gadget/udc/Kconfig > +++ b/drivers/usb/gadget/udc/Kconfig > @@ -55,7 +55,7 @@ config USB_LPC32XX > =20 > config USB_ATMEL_USBA > tristate "Atmel USBA" > - depends on AVR32 || ARCH_AT91 > + depends on ((AVR32 && !OF) || ARCH_AT91) any chance you can add || COMPILE_TEST here ? I'd like to make sure this builds on my end too. --=20 balbi --cmJC7u66zC7hs+87 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV/tugAAoJEIaOsuA1yqRE6/AP/0lhZnWA2Uh0S9toNUiotGDX ugUlqDdCnlOAzjupWcwbf1i7MabX/7US7EGR1y1f8cK5+oMDiQ2TqrqEDlOhsKKt VDx6TThXO/LD28wjKNSSWJ8r/ojK04ST1RxHPAfAazhS3z++yWTQqAWnBuvIRPF1 AhW0W7n6BaiYreMla19d4ubImN6dVlUMx9+HUqhhhvq7fNlANlYumUMpabh62ns+ Aj0yeC20PqRl/qr0TB+EjyW38qlV4IoHf0QHktr9R6iRJ9iXqRt+ViVAj4JPnEBP 3OvOxwTiwS7zBOKEs15bPD41Gb9JQJ0qhbDVe5ijdKKP3ast/YFk+9SuCZLtBiC1 q0b5WReS1eRp42d5om+bHyMXsO2EP6HyrrWk8jYmXZ3BtDaW0CLljm/u4Nmb2zhV +7uBC8SDYyMBKsk4pIsonF1me4sV/66zYig6/Az4uIqJbrCxnN2PB2iCum/l6K3a o8hDgybl2BJaFolMz7ZOT7ZM17sTJu/nITBXQmbWe7Kgnw4HwW9sEF/ZjHqnzvjw 5JDhBFyU0nEsflUQIiwTE+QOqu7c7a5u/FmU7iq2Dji7DlmsPCt3Z4GAhbyzYKiQ PPSzWtCxCC0uIfmfVfVUEHGP0dO5Vykoh5Yi+OPiLLDtXOT+sIM9+KW9QUJzfPSg 76hLvlQ4tJMBYEPxIrzY =Z6k7 -----END PGP SIGNATURE----- --cmJC7u66zC7hs+87--