From: Greg KH <gregkh@linuxfoundation.org>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com,
jasowang@redhat.com
Subject: Re: [PATCH 4/5] hv: kvp: use wrappers to propaigate state
Date: Sun, 20 Sep 2015 22:26:25 -0700 [thread overview]
Message-ID: <20150921052625.GB24350@kroah.com> (raw)
In-Reply-To: <1442363874-22508-4-git-send-email-kys@microsoft.com>
On Tue, Sep 15, 2015 at 05:37:53PM -0700, K. Y. Srinivasan wrote:
> From: Olaf Hering <olaf@aepfle.de>
>
> The "state" is used by several threads of execution.
> Propagate the state to make changes visible. Also propagate context
> change in kvp_on_msg.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
> drivers/hv/hv_kvp.c | 39 +++++++++++++++++++++------------------
> 1 files changed, 21 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c
> index 74c38a9..778d353 100644
> --- a/drivers/hv/hv_kvp.c
> +++ b/drivers/hv/hv_kvp.c
> @@ -61,7 +61,7 @@
> */
>
> static struct {
> - int state; /* hvutil_device_state */
> + enum hvutil_device_state state;
> int recv_len; /* number of bytes received. */
> struct hv_kvp_msg *kvp_msg; /* current message */
> struct vmbus_channel *recv_channel; /* chn we got the request */
> @@ -74,6 +74,9 @@ static struct {
> */
> static int dm_reg_value;
>
> +#define kvp_get_state() hvutil_device_get_state(&kvp_transaction.state)
> +#define kvp_set_state(s) hvutil_device_set_state(&kvp_transaction.state, s)
> +
> static void kvp_send_key(struct work_struct *dummy);
>
>
> @@ -122,8 +125,8 @@ static void kvp_timeout_func(struct work_struct *dummy)
> kvp_respond_to_host(NULL, HV_E_FAIL);
>
> /* Transaction is finished, reset the state. */
> - if (kvp_transaction.state > HVUTIL_READY)
> - kvp_transaction.state = HVUTIL_READY;
> + if (kvp_get_state() > HVUTIL_READY)
> + kvp_set_state(HVUTIL_READY);
>
And what if the state changed the line after this? Oops, your code is
hosed. See, you need a lock, do this correctly.
greg k-h
next prev parent reply other threads:[~2015-09-21 5:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 0:37 [PATCH 0/5] Drivers: hv: Miscellaneous fixes K. Y. Srinivasan
2015-09-16 0:37 ` [PATCH 1/5] Drivers: hv: vmbus: fix init_vp_index() for reloading hv_netvsc K. Y. Srinivasan
2015-09-16 0:37 ` [PATCH 2/5] hv: add helpers to handle hv_util device state K. Y. Srinivasan
2015-09-21 5:25 ` Greg KH
2015-09-21 10:26 ` Olaf Hering
2015-09-21 11:25 ` Vitaly Kuznetsov
2015-09-21 12:17 ` Olaf Hering
2015-09-21 13:37 ` Vitaly Kuznetsov
2015-09-21 16:45 ` KY Srinivasan
2015-09-21 16:34 ` KY Srinivasan
2015-09-21 16:43 ` Greg KH
2015-09-21 17:00 ` KY Srinivasan
2015-09-16 0:37 ` [PATCH 3/5] hv: fcopy: use wrappers to propagate state K. Y. Srinivasan
2015-09-16 0:37 ` [PATCH 4/5] hv: kvp: use wrappers to propaigate state K. Y. Srinivasan
2015-09-21 5:26 ` Greg KH [this message]
2015-09-21 10:18 ` Olaf Hering
2015-09-21 16:31 ` KY Srinivasan
2015-09-21 16:16 ` KY Srinivasan
2015-09-16 0:37 ` [PATCH 5/5] hv: vss: use wrappers to propagate state K. Y. Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921052625.GB24350@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).