From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932224AbbIULLK (ORCPT ); Mon, 21 Sep 2015 07:11:10 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33687 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753810AbbIULLI (ORCPT ); Mon, 21 Sep 2015 07:11:08 -0400 Date: Mon, 21 Sep 2015 16:40:57 +0530 From: Sudip Mukherjee To: Felipe Balbi Cc: Haavard Skinnemoen , Hans-Christian Egtvedt , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency Message-ID: <20150921111044.GA21986@sudip-pc> References: <1442682779-20077-1-git-send-email-sudipm.mukherjee@gmail.com> <1442682779-20077-3-git-send-email-sudipm.mukherjee@gmail.com> <20150920161528.GB1447@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150920161528.GB1447@saruman.tx.rr.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 20, 2015 at 11:15:28AM -0500, Felipe Balbi wrote: > On Sat, Sep 19, 2015 at 10:42:58PM +0530, Sudip Mukherjee wrote: > > While building allmodconfig on avr32 the build failed with the error: > > "at91_pmc_base" [drivers/usb/gadget/udc/atmel_usba_udc.ko] undefined! > > > > On checking the code it turned out that if CONFIG_OF is defined then it > > is using at91_pmc_read() which is using at91_pmc_base. And unless > > COMMON_CLK_AT91 is defined we donot have at91_pmc_base. And > > COMMON_CLK_AT91 is available with AT91 architecture. > > Mention the dependency such that this driver builds with avr32 only if > > OF is not enabled. > > > > Signed-off-by: Sudip Mukherjee > > --- > > > > Tested build with at91_dt_defconfig and allmodconfig of avr32. Build log > > at: > > https://travis-ci.org/sudipm-mukherjee/parport/builds/81168845 > > > > drivers/usb/gadget/udc/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig > > index 9a3a6b0..cdbff54 100644 > > --- a/drivers/usb/gadget/udc/Kconfig > > +++ b/drivers/usb/gadget/udc/Kconfig > > @@ -55,7 +55,7 @@ config USB_LPC32XX > > > > config USB_ATMEL_USBA > > tristate "Atmel USBA" > > - depends on AVR32 || ARCH_AT91 > > + depends on ((AVR32 && !OF) || ARCH_AT91) > > any chance you can add || COMPILE_TEST here ? I'd like to make > sure this builds on my end too. With "depends on ((AVR32 && !OF) || ARCH_AT91 || COMPILE_TEST)" normal allmodconfig builiding for x86_64 failed with: drivers/usb/gadget/udc/atmel_usba_udc.c: In function ‘usba_start’: drivers/usb/gadget/udc/atmel_usba_udc.c:1783:25: error: ‘USBA_ENABLE_MASK’ undeclared (first use in this function) usba_writel(udc, CTRL, USBA_ENABLE_MASK); ^ drivers/usb/gadget/udc/atmel_usba_udc.c: In function ‘usba_stop’: drivers/usb/gadget/udc/atmel_usba_udc.c:1800:25: error: ‘USBA_DISABLE_MASK’ undeclared (first use in this function) usba_writel(udc, CTRL, USBA_DISABLE_MASK); ^ Looks like USBA_DISABLE_MASK and USBA_ENABLE_MASK is defined under #if defined(CONFIG_AVR32). :( regards sudip