From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756718AbbIUMsS (ORCPT ); Mon, 21 Sep 2015 08:48:18 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33813 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756677AbbIUMsR (ORCPT ); Mon, 21 Sep 2015 08:48:17 -0400 Date: Mon, 21 Sep 2015 18:18:04 +0530 From: Sudip Mukherjee To: Felipe Balbi Cc: Thomas Dahlmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-geode@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 00/16] usb: gadget: amd5536udc: fix memory leaks Message-ID: <20150921124804.GA10767@sudip-pc> References: <1442243583-24741-1-git-send-email-sudipm.mukherjee@gmail.com> <20150918183954.GD7636@saruman.tx.rr.com> <20150919035438.GA666@sudip-pc> <20150920081242.GB20592@sudip-pc> <20150920161736.GD1447@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150920161736.GD1447@saruman.tx.rr.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 20, 2015 at 11:17:36AM -0500, Felipe Balbi wrote: > On Sun, Sep 20, 2015 at 01:42:42PM +0530, Sudip Mukherjee wrote: > > On Sat, Sep 19, 2015 at 09:24:38AM +0530, Sudip Mukherjee wrote: > > > On Fri, Sep 18, 2015 at 01:39:54PM -0500, Felipe Balbi wrote: > > > > On Mon, Sep 14, 2015 at 08:42:47PM +0530, Sudip Mukherjee wrote: > > > > > This amd5536udc was a complete mess. The major problems that i could > > > > > find are: > > > > > > > > > > > > > > > run checkpatch.pl and try again > > > > > Anyways, I will fix up all the warnings and send v2. > > > > I guess v2 is not required any more. The main thing that this series was > > trying to do has already been done by: > > 6527cc27761a ("usb: gadget: amd5536udc: fix error handling in udc_pci_probe()") > > all right, see if there's anything missing, please. I think something still needs to be done there. I will send a v2 for your review. regards sudip