From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932233AbbIUKKe (ORCPT ); Mon, 21 Sep 2015 06:10:34 -0400 Received: from ozlabs.org ([103.22.144.67]:37199 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932114AbbIUKKb (ORCPT ); Mon, 21 Sep 2015 06:10:31 -0400 Date: Mon, 21 Sep 2015 20:10:29 +1000 From: Stephen Rothwell To: Michal Hocko , Vladimir Davydov Cc: Andrew Morton , Tejun Heo , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the akpm-current tree Message-ID: <20150921201029.7d613e65@canb.auug.org.au> In-Reply-To: <20150921075853.GA19811@dhcp22.suse.cz> References: <20150921141039.5bfbb9ca@canb.auug.org.au> <20150921075853.GA19811@dhcp22.suse.cz> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, Vladimir, On Mon, 21 Sep 2015 09:58:53 +0200 Michal Hocko wrote: > > AFAIU your fix is correct but using > cgroup_subsys_on_dfl(memory_cgrp_subsys) is more appropriate: > diff --git a/mm/vmscan.c b/mm/vmscan.c > index d62924ee8022..c3df03add73e 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -176,7 +176,7 @@ static bool sane_reclaim(struct scan_control *sc) > if (!memcg) > return true; > #ifdef CONFIG_CGROUP_WRITEBACK > - if (cgroup_on_dfl(memcg->css.cgroup)) > + if (cgroup_subsys_on_dfl(memory_cgrp_subsys)) > return true; > #endif > return false; Thanks, I will do that from tomorrow. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au