From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756877AbbIUVMe (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 Sep 2015 17:12:34 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45145 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756490AbbIUVMb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 Sep 2015 17:12:31 -0400
Date: Mon, 21 Sep 2015 14:10:53 -0700
From: Mark Brown <broonie@kernel.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, linux-pwm@vger.kernel.org,
        Liam Girdwood <lgirdwood@gmail.com>, Jingoo Han <jingoohan1@gmail.com>,
        Lee Jones <lee.jones@linaro.org>, linux-fbdev@vger.kernel.org,
        Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
        Jacek Anaszewski <j.anaszewski@samsung.com>,
        linux-leds@vger.kernel.org,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        linux-sunxi@googlegroups.com, Heiko Stuebner <heiko@sntech.de>,
        linux-rockchip@lists.infradead.org,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Daniel Mack <daniel@zonque.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Robert Jarzmik <robert.jarzmik@free.fr>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Doug Anderson <dianders@google.com>,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
Message-ID: <20150921211053.GF30445@sirena.org.uk>
References: <1442828009-6241-1-git-send-email-boris.brezillon@free-electrons.com>
 <1442828009-6241-13-git-send-email-boris.brezillon@free-electrons.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="GVmdUcABewnKtUm9"
Content-Disposition: inline
In-Reply-To: <1442828009-6241-13-git-send-email-boris.brezillon@free-electrons.com>
X-Cookie: NOBODY EXPECTS THE SPANISH INQUISITION!
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: 70.35.39.2
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH v3 12/12] regulator: pwm: properly initialize the ->state
 field
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--GVmdUcABewnKtUm9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Sep 21, 2015 at 11:33:29AM +0200, Boris Brezillon wrote:
> The ->state field is currently initialized to 0, thus referencing the
> voltage selector at index 0, which might not reflect the current voltage
> value.
> If possible, retrieve the current voltage selector from the PWM state, else
> return -EINVAL.

Acked-by: Mark Brown <broonie@kernel.org>

--GVmdUcABewnKtUm9
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWAHJYAAoJECTWi3JdVIfQxPsH/0ivENz0SB+aLAU4UrJXE0ky
Q1xie9LI6dab8dc6e7rmAOSDhkMJ1DvCyAEqSDqcFvsdxh2gdu2cz9cQ7divIjjP
XFJwuyHftuGzRWH3a1J9gp8VT/PyEvUUMWXnq2NrKGOZBTetd8WncixWV0ArxkZf
5BEOf1pkq4FHYD9pwRrhk3qJWPPUjjhCzziUC6o3Q1Mge29gIBAj8KE4VPRI4MCJ
M6Se8MJy1VcBml1eNoYcsDgwBA+j74sDCLuAb2YrX0naLxHqn1VUVY4V4HwwH4cx
XrXTdGmq9ke/jjBaKKRc8mXi6H4s3taKy2HNj6clxBH7bQsdoMD1GWgalYYdErE=
=8m4a
-----END PGP SIGNATURE-----

--GVmdUcABewnKtUm9--