From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933261AbbIVXPx (ORCPT ); Tue, 22 Sep 2015 19:15:53 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:36958 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758832AbbIVXPJ (ORCPT ); Tue, 22 Sep 2015 19:15:09 -0400 Date: Tue, 22 Sep 2015 16:15:08 -0700 (PDT) Message-Id: <20150922.161508.1548783571595972129.davem@davemloft.net> To: a.hajda@samsung.com Cc: linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, m.szyprowski@samsung.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 22/38] orinoco: fix checking for default value From: David Miller In-Reply-To: <1442842450-29769-23-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> <1442842450-29769-23-git-send-email-a.hajda@samsung.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 22 Sep 2015 16:15:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrzej Hajda Date: Mon, 21 Sep 2015 15:33:54 +0200 > Thresholds uses -1 to indicate that default value should be used. > Since thresholds are unsigned sign checking makes no sense. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda Applied.