From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757177AbbIVGwm (ORCPT ); Tue, 22 Sep 2015 02:52:42 -0400 Received: from mail-bl2on0103.outbound.protection.outlook.com ([65.55.169.103]:39190 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756488AbbIVGwk (ORCPT ); Tue, 22 Sep 2015 02:52:40 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; samsung.com; dkim=none (message not signed) header.d=none;samsung.com; dmarc=none action=none header.from=freescale.com; Date: Tue, 22 Sep 2015 13:39:41 +0800 From: Peter Chen To: Felipe Balbi CC: Felipe Tonello , USB list , Kernel development list , Greg Kroah-Hartman , Andrzej Pietrasiewicz Subject: Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue Message-ID: <20150922053940.GA20558@shlinux2> References: <1442597788-4306-1-git-send-email-eu@felipetonello.com> <20150922040442.GH22310@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150922040442.GH22310@saruman.tx.rr.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC004;1:fLiVYVeYniIUPyMYBbdlBWWxsCF8THKoekuTJkTOeoE9V75Wn3+tKLRvJ42dIi3guVynokRgYO2etiEfJa1IMPrP1e5NLuzvOmVs7L0bPAXsFwcssDIBD82MTLlorTWMgosw6xSxuY8B/ayQJkmwLUaPWc2ilAzplEVchbMurQG9nxi8bG2vgTfjgcXGMrKGz+xb7BDCWRzuIp5ptg0amyXQPaez7rnfhD+ovbMXt4LiLo8kA54q78Kr3JaQipxNHXkjpQLYSPrnQUBtAKddrpfILPSkSPawEyMgi3exCqI3u3eO7wm22zis4kQcxkssaIqk7wtYZZEdajasFn2DrCmKyFC0iPt2fjGk1gt+h7PMgLyAx6Gp7YYRODpNJEsR X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(1110001)(339900001)(24454002)(377454003)(199003)(189002)(5001960100002)(5007970100001)(6806004)(85426001)(46406003)(33656002)(33716001)(23726002)(106466001)(11100500001)(50466002)(110136002)(4001540100001)(5001830100001)(46102003)(104016003)(97736004)(87936001)(2950100001)(76176999)(54356999)(105606002)(189998001)(5001860100001)(77096005)(47776003)(97756001)(19580395003)(77156002)(62966003)(92566002)(5001920100001)(50986999)(81156007)(68736005)(64706001)(4001350100001)(19580405001)(86362001)(83506001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0301MB1276;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1276;2:qR9zDElh7eHT20YtXr6Ww3tx2mJrJOivJxYB6NAIHujBAw7Mje9UeBkgtOcIrwlM0Qu/S001bplH3Q3RYTNRJxnbxFXmwpy0O7HibbSX2Wyh3hInHTyNmnHlyxuezN6dQCJ3bX3scOybe1m7d3YZ1JoD1pCzl+X2l83Jw4FcwFE=;3:KumVpqvdX1adsblXA3sr5rupmo9ENBnLkjGONzHE4GvERo7tGiIFysEEknAFtGHj4/jflfV9v//4Qj/pCLNMqLYaN6IX4L+tEmIDGzr1emrN/5gEkXOqzWs0n3+UMt1rEscZD5+kgrPo8SHpPGwsCq0e38vPPyesGNJvMyFff7/o5zkdch6CvpgorSUesjpHN2Fimlq+y/IDnT026xa8uLVW6aYpmUYysaxCCnmX/fM=;25:PTb6l5Xbwdvujoc2ZxJWtvLF0Vy96rS1+83g2HOUlXGiEd7ESv8vUwxDuHhZYsblWJZt6Oc4gv4G8NiVNF2T5YoMq/XSyWQX4d4QTxncvdtvq7l0bMDD5ulIcC8xktAYSatMjhB5bhkmN5hXhaMSBbetMdwCdmNCvFJN9vD3i6LU2Q/h89PmkDQuMbvJsXZH+gjzGfkx+2et0c1jMdb5L1CSBLtUv/go7kDd6l3IggwS3rHwjG9Szps4+e1OvpwjPVj+cMAACd48YJL6uRMtJA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1276; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1276;20:2gkFHf7QxfPIe3nZfV/guMIYHe3kTtxQohM91WN4BUUTer0ZCjNZml3E/3JzPY1GEe7pFarrxTl9PpOcAYjR2lZr9L43vaEthiwidXQiQNr/Oe/bcr9I2ak9Bzl5W0PMlk8HtbKtOBnewz3pwyWSvJ7KnnDJgk8bzWHrTbMyhSQyWiGYaC3DyioK3mZ8m7Wl7WY2x2KbZ36qTzmgzprL55O55307EZUyku1Bu88eel2pRjpEHu6OX72Ow96l+VAc84C1sK1W+ZFkXlKOnOrJP0QjlxIleFuTboCOHxi8nVf45ML06vxBTTEI4jqlLsjg1nuRN5/eyF3CO0MIZ6frrFWaizBJ9+OixKUPfLyyYIc=;4:RxEmVuSb6vwNM3Q+7emekLlIccWqW1YopGb1FInTpEGQOmAYJRzQlfy+GHMcwJQ1IVCiG3NWyiQzwssapPps3gNudKOY6L7vmxwGvpfhRK2GhHFeBme0IOYP1mtlfy9NdZZgPNpsQ/T53Gj99vVOK4x6Gzf3DgwTcJsFC2zQzKZ5rGw0dNZ9WIZpjOHaIA18RwbqK9L6U5vc/fflbB6oIOh4xJ7U4YJzzMTAZfk4jtppEFNofaGI9Uj9/3zMPQFXwOkBn8Vl8+kR9Hjv+nuK0PGBycqSL1LaZ3hFJudY4DJZ6pGB0rgMEbj/DWxp9mVE29mjWeKYKDE/vGV46mIoX0BBIPovhYYupZJ/E+gddm4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401041)(8121501046)(520078)(5005006)(3002001);SRVR:CY1PR0301MB1276;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1276; X-Forefront-PRVS: 0707248B64 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0301MB1276;23:wEZ5PlDIX2tMqgE8D8lNyPJuMs6k6euouqAV8ii?= =?us-ascii?Q?2pOXva392AZZX+fT0wburu8HpkRgWfJR7DYjZi9Dw28buxKG7TFNp1cNO8wd?= =?us-ascii?Q?I11J7bRyKCQSbWJS9jPAwrTSeB3BKutfopBI/GofdVu12PPmZ0PmMdiCmTPB?= =?us-ascii?Q?S0tq0DDeihplJlDO9Ii2FGcW3PGUYH1WhZeAecwg0b7FfLkCukVt+fxgwdCE?= =?us-ascii?Q?4eAA/JMmvdY/1hmgD4/kk1BS/l2Z+lVFvvaHU34A+Y1sDyoRKhpP9yrns9o2?= =?us-ascii?Q?YaieUmXtmLsHJc5YDaLtH/Gek649hMgJPq434Lx/4kQ31Nr7qaLvSUTGl+D/?= =?us-ascii?Q?x6MFY+q4Iv6HeCMzrbv+gKrMca+jeCFagORC98JAxGiLpwgrKzeZiofbniNp?= =?us-ascii?Q?sipkvPXoZnX11JmF9qHfMZKwW0OHT52xKpO16fZOGkgfb26rHWjL8NRSeQaU?= =?us-ascii?Q?gs1SYR5j3K8BXC1QJByvR4b7sDQgcMqDpOLoYGPqB2JSt0ivQ6LtmY8tyDT2?= =?us-ascii?Q?WoJNDch59d0wIve0BfdBvvWpK2nIATuDUM63OkVXEYIy7L7Amw7stg7azqmc?= =?us-ascii?Q?GvWbzAUSI3g+WBFu03hoRilCvqyOy92ABLvka14YbDyeHmu1ODTj0OJBYN6x?= =?us-ascii?Q?Mksg7Ly0TJ1w+Qdd669vQUrbjxRbtQkNclgxPtddDLtthsMSX86cRgPXfnu5?= =?us-ascii?Q?Tu8qqfC4dD/rpYWRiBZbVvhrslGjSbL5ChkFoWOC0tZKV723g7e5fgmqNZGi?= =?us-ascii?Q?IfGIx+XGEkQI5UoF/+1Q8UBRUo4Xg7dO/bkjH0dCid7P0q/qFe/einxeVj59?= =?us-ascii?Q?OwVUOwwZFF6sR56TNcxKmHDO9QmA7KI4rp0Cnujc3OuueV7p1EvBZ7loPIwD?= =?us-ascii?Q?ZRFN51qbddpniSWXHTj5bGO1mXflj8OnJ8xyxx1le+UqE3JrPb8PAMUurn2K?= =?us-ascii?Q?tWqIADlWWlTAmeEzLHkrgZgUlUDv3KSx7U/UHLVUdJB1MmGeC55MxHZCDnyX?= =?us-ascii?Q?OqkBGJKmA4NhUqCn2x2WUsq8hT8Hd0wn6kjpDRvj7rpg6U9nA74mfQMj3+78?= =?us-ascii?Q?cillfzloGW6NG+7qp1vTvlguKHZXFBi+EN0upkisbBJMqixM07rDk8orvio0?= =?us-ascii?Q?eA+KjpQyRkDYiR0b2mQcUa9Q9hR/b7O3HtPTbR9zf5KsItc1vB5d4e/D1Dc4?= =?us-ascii?Q?6TeyIMmNvLFm3sJDrQIEfg5qe3BGQjz9DfhJzxCabLZNCJtHG9j1enxdKI3w?= =?us-ascii?Q?G4rMaCw5Ao4N8OEAj9VNBE8t+5WxS83HjWgCs61dKxfG4TAuC2+XHc3m7miV?= =?us-ascii?Q?C6nMuVY14Nr6GxXoFVPHzWqo=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1276;5:iQz3Yx6LJB8VARfKzIm+sGXT6yhyPXG8b8X0b2xIfJkRCbfOI3+Huoc9zQxnaIumFwQxLWrdVGazLQAed+349zkvyaLRhWFu+c5BFmmqkBseiCySOoSV4SC8EdMdUGwgH1ryl3PW4vXydHYV9p3C2w==;24:iKRkUoy3q/QLaA6YJfZCmLK3SNSM/soyt/iKm1Pqog2bvqIYnFuHkmbqKdzZWmf8DfAApalhUdVD3UgfA2uk95UWmup5ZdrHAoQ/N1IAGfw=;20:SUIOPBYKgu4Brw+6MEaZeuSlZkyGoRe3CEXK/TWLAESWOiNWDy1rKc+NoPtjjGL+EtHDQ/+aFbS0yAaHnW3ZNg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2015 06:52:36.3795 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1276 X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1562;2:JlQQPeTWXujYPH/P3u62CEh9KQx1h8mwDUT3fgtqitk/etbZ/vr+nDuJytHokkNMiimSCNHzoqkFe1LqvDfz11uh1yF6MxaVtGT9q+E0Qm8lYRWof0TJzjKmHOsyh6PU3ZKDJpaD783uSRAuIZi/BDykdUwaq3jwfkxwn0uYJA4=;23:QxKuxTLFjFI9OOekC3gtvd0jtrm4Hg92jj/3NyuQjCm8yWa2pV0UpujP1tF00awfJ0Y8jdGJWbwaEcBTbuedsag/XD82ePy2AZHHuJhlsXclZJ0rD+S6Z7CCUetH9xm68/NGULjrDknlFrrOR5aa8HCTYMnBXvYw0CU9B2Vzudr1kW1VyZxKP2QLCMEthG2+ X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 11:04:42PM -0500, Felipe Balbi wrote: > Hi, > > On Mon, Sep 21, 2015 at 10:21:31AM +0100, Felipe Tonello wrote: > > Hi Balbi, > > > > On Fri, Sep 18, 2015 at 6:36 PM, wrote: > > > From: "Felipe F. Tonello" > > > > > > f_midi is not checking whether there is an error on usb_ep_queue > > > request, ignoring potential problems, such as memory leaks. > > > > > > Signed-off-by: Felipe F. Tonello > > > --- > > > > > > Changes for v2: > > > - Update code style. > > > > > > Changes for v3: > > > - Use ip_ep instead of out_ep. Fixed typo in commit message. > > > > I forgot to add v3 to the patch subject, so it queued here instead. Do > > you want me to re-send as v3? > > you need to ask Peter, he's the chipidea maintainer. Peter ? > I have queued the first two for chipidea changes, the third one is for gadget change. -- Best Regards, Peter Chen