From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758449AbbIVPoE (ORCPT ); Tue, 22 Sep 2015 11:44:04 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:44099 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758428AbbIVPoC (ORCPT ); Tue, 22 Sep 2015 11:44:02 -0400 Date: Tue, 22 Sep 2015 17:43:51 +0200 From: Ralf Baechle To: Andrzej Hajda Cc: linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Marek Szyprowski , Markos Chandras , Chris Dearman , linux-mips@linux-mips.org Subject: Re: [PATCH 36/38] MIPS: remove invalid check Message-ID: <20150922154350.GA16339@linux-mips.org> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> <1442842450-29769-37-git-send-email-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442842450-29769-37-git-send-email-a.hajda@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 03:34:08PM +0200, Andrzej Hajda wrote: > Unsigned values cannot be lesser than zero. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Chris Dearman's original commit 9318c51acd9689505850152cc98277a6d6f2d752 ([MIPS] MIPS32/MIPS64 secondary cache management) introduced these less than zero checks in 2.6.18. They're fortunately entirely harmless. Patch queued for 4.4. Thanks! Ralf