From: Daniel Vetter <daniel@ffwll.ch>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH v2 5/6] virtio-gpu: add basic prime support
Date: Tue, 22 Sep 2015 18:15:44 +0200 [thread overview]
Message-ID: <20150922161544.GY3383@phenom.ffwll.local> (raw)
In-Reply-To: <1442935469.13084.36.camel@redhat.com>
On Tue, Sep 22, 2015 at 05:24:29PM +0200, Gerd Hoffmann wrote:
> > > +int virtgpu_gem_prime_mmap(struct drm_gem_object *obj,
> > > + struct vm_area_struct *area)
> > > +{
> > > + WARN_ONCE(1, "not implemented");
> > > + return ENOSYS;
> >
> > This can get called by userspace, so please don't WARN here. Also missing
> > negate sign:
> >
> > return -ENOSYS;
>
> Hmm now checkpatch throws a warning at me:
>
> <quote>
> WARNING: ENOSYS means 'invalid syscall nr' and nothing else
> #12: FILE: drivers/gpu/drm/virtio/virtgpu_prime.c:70:
> + return -ENOSYS;
> </quote>
>
> I guess I should use something else then (here and elsewhere in the
> file)? Maybe -EINVAL? Other suggestions?
-ENODEV is what we occasionally pick. drm is fairly creative at errno
abuse, e.g. we already use -ENOENT to signal any kind of lookup failure in
ioctls (even if the fd itself is obviously there so not possible that the
fd isn't there).
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2015-09-22 16:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442828417-6165-1-git-send-email-kraxel@redhat.com>
2015-09-21 9:40 ` [PATCH v2 1/6] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_locked Gerd Hoffmann
2015-09-21 9:40 ` [PATCH v2 2/6] virtio-gpu: add & use virtio_gpu_queue_fenced_ctrl_buffer Gerd Hoffmann
2015-09-21 9:40 ` [PATCH v2 3/6] virtio-gpu: wait for cursor updates finish Gerd Hoffmann
2015-09-21 9:40 ` [PATCH v2 4/6] virtio-gpu: add 3d/virgl support Gerd Hoffmann
2015-09-21 10:15 ` Michael S. Tsirkin
2015-09-22 15:18 ` Gerd Hoffmann
2015-09-21 9:40 ` [PATCH v2 5/6] virtio-gpu: add basic prime support Gerd Hoffmann
2015-09-22 9:40 ` Daniel Vetter
2015-09-22 15:24 ` Gerd Hoffmann
2015-09-22 16:15 ` Daniel Vetter [this message]
2015-09-21 9:40 ` [PATCH v2 6/6] virtio-gpu: mark as a render gpu Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922161544.GY3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).