From: Tejun Heo <tj@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
"David Miller" <davem@davemloft.net>,
"Cong Wang" <cwang@twopensource.com>,
tom@herbertland.com, kafai@fb.com, kernel-team@fb.com,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
"Jiří Pírko" <jiri@resnulli.us>,
"Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
"Thomas Graf" <tgraf@suug.ch>,
"Scott Feldman" <sfeldma@gmail.com>
Subject: Re: [PATCH v2] netlink: Replace rhash_portid with bound
Date: Tue, 22 Sep 2015 15:50:59 -0400 [thread overview]
Message-ID: <20150922195059.GF17659@mtj.duckdns.org> (raw)
In-Reply-To: <CA+55aFy3k_NouhizkAkiZkuTYTqEKQZCnz8yOzrSH8o4+vjKUw@mail.gmail.com>
Hello,
On Tue, Sep 22, 2015 at 12:28:45PM -0700, Linus Torvalds wrote:
> Both acquire and smp_rmb() are equally free on x86.
Was this always like this? Ah, okay, from 2007. Was thinking it's
still doing an actual rmb. Talk about being confused.
> It appears that we don't do the X86_PPRO_FENCE bug handling for
> acquire, but I guess we should.
Hmmm? We're doing that. PPRO_FENCE makes both acquire and release
use smp_mb().
Thanks.
--
tejun
next prev parent reply other threads:[~2015-09-22 19:51 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 2:29 Possible netlink autobind regression Tejun Heo
2015-09-17 3:08 ` Herbert Xu
2015-09-17 3:41 ` Herbert Xu
2015-09-17 5:02 ` Cong Wang
2015-09-17 5:15 ` Herbert Xu
2015-09-17 11:25 ` Thomas Graf
2015-09-17 11:30 ` Tejun Heo
2015-09-18 6:36 ` [PATCH v3] netlink: Fix autobind race condition that leads to zero port ID Herbert Xu
2015-09-18 11:16 ` [PATCH v4] " Herbert Xu
2015-09-21 5:55 ` David Miller
2015-09-21 6:06 ` Herbert Xu
2015-09-21 6:11 ` David Miller
2015-09-21 13:34 ` netlink: Replace rhash_portid with bound Herbert Xu
2015-09-21 18:20 ` Tejun Heo
2015-09-22 3:38 ` [PATCH v2] " Herbert Xu
2015-09-22 16:10 ` Tejun Heo
2015-09-22 18:42 ` Linus Torvalds
2015-09-22 18:53 ` Tejun Heo
2015-09-22 19:28 ` Linus Torvalds
2015-09-22 19:50 ` Tejun Heo [this message]
2015-09-22 20:03 ` Linus Torvalds
2015-09-22 20:36 ` Bjørn Mork
2015-09-22 21:04 ` Linus Torvalds
2015-09-23 6:13 ` Herbert Xu
2015-09-23 15:54 ` Tejun Heo
2015-09-24 2:30 ` Herbert Xu
2015-09-24 2:46 ` Tejun Heo
2015-09-24 2:54 ` Herbert Xu
2015-09-24 3:06 ` Tejun Heo
2015-09-24 3:21 ` Herbert Xu
2015-09-24 3:29 ` Tejun Heo
2015-09-24 3:31 ` Herbert Xu
2015-09-24 3:41 ` Tejun Heo
2015-09-24 3:42 ` Herbert Xu
2015-09-24 3:43 ` Tejun Heo
2015-09-24 3:44 ` Herbert Xu
2015-09-24 19:11 ` David Miller
2015-09-24 20:05 ` Tejun Heo
2015-09-25 1:43 ` netlink: Add barrier to netlink_connect for theoretical case Herbert Xu
2015-09-25 3:24 ` Linus Torvalds
2015-09-25 3:39 ` Herbert Xu
2015-09-25 15:09 ` Tejun Heo
2015-09-25 15:01 ` Tejun Heo
2015-09-26 13:16 ` netlink: Add netlink_bound helper and use it in netlink_getname Herbert Xu
2015-09-26 18:09 ` Tejun Heo
2015-09-26 19:41 ` Herbert Xu
2015-09-26 19:45 ` Tejun Heo
2015-09-26 19:49 ` Herbert Xu
2015-09-26 19:52 ` Tejun Heo
2015-09-26 19:55 ` Herbert Xu
2015-09-26 20:05 ` Tejun Heo
2015-09-26 20:10 ` Herbert Xu
2015-09-26 20:17 ` Tejun Heo
2015-09-21 20:52 ` [PATCH] netlink: Replace rhash_portid with load_acquire protected boolean Tejun Heo
2015-09-18 13:37 ` [PATCH v3] netlink: Fix autobind race condition that leads to zero port ID Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922195059.GF17659@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jiri@resnulli.us \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=sfeldma@gmail.com \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).