From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756164AbbIWRPZ (ORCPT ); Wed, 23 Sep 2015 13:15:25 -0400 Received: from cassarossa.samfundet.no ([193.35.52.29]:49929 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755842AbbIWRPY (ORCPT ); Wed, 23 Sep 2015 13:15:24 -0400 Date: Wed, 23 Sep 2015 19:15:16 +0200 From: Hans-Christian Egtvedt To: Sudip Mukherjee Cc: Haavard Skinnemoen , Felipe Balbi , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 1/3] avr32: fix build failure Message-ID: <20150923171516.GA15625@samfundet.no> References: <1442682779-20077-1-git-send-email-sudipm.mukherjee@gmail.com> <1442682779-20077-2-git-send-email-sudipm.mukherjee@gmail.com> <20150921060942.GA17632@samfundet.no> <20150921063901.GA29279@sudip-pc> <20150921073300.GA9368@samfundet.no> <20150921080129.GA13176@sudip-pc> <20150923155601.GC13153@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150923155601.GC13153@sudip-pc> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Around Wed 23 Sep 2015 21:26:01 +0530 or thereabout, Sudip Mukherjee wrote: > On Mon, Sep 21, 2015 at 01:31:44PM +0530, Sudip Mukherjee wrote: >> On Mon, Sep 21, 2015 at 09:33:00AM +0200, Hans-Christian Egtvedt wrote: >> > Around Mon 21 Sep 2015 12:09:01 +0530 or thereabout, Sudip Mukherjee wrote: >> > > On Mon, Sep 21, 2015 at 08:09:42AM +0200, Hans-Christian Egtvedt wrote: >> > >> Around Sat 19 Sep 2015 22:42:57 +0530 or thereabout, Sudip Mukherjee wrote: >> > >> > While building avr32 with allmodconfig, the build used to fail with the >> > >> > message: >> > >> > error: implicit declaration of function 'pci_iomap' >> > >> > error: implicit declaration of function 'pci_iounmap' >> > >> >> > >> What has changed recently that start pulling in these? AVR32 does not have >> > >> PCI at all, and will never have it either. Is this exposing a bug somewhere >> > >> else? >> > > It looks like pci_iomap and pci_iounmap doesnot depend on CONFIG_PCI. >> > > So drivers/net/ethernet/via/via-rhine.c is calling these functions even >> > > if PCI is disabled. The build log is at: >> > > https://travis-ci.org/sudipm-mukherjee/parport/jobs/81127188 >> > > >> > > You can find a similar discussion at: >> > > http://www.linux-mips.org/archives/linux-mips/2013-06/msg00510.html >> > >> > If multiple architectures have similar problems, then a more global >> > definition of these unused functions could be added. >> > >> > Just move the implementation for MIPS into include/asm-generic/io.h ? >> > >> > That way we do not have to implement and identical stub for every device not >> > supporting PCI. >> >> include/asm-generic/io.h is having: >> #ifndef CONFIG_GENERIC_IOMAP >> struct pci_dev; >> extern void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned >> long max); >> >> #ifndef pci_iounmap >> #define pci_iounmap pci_iounmap >> static inline void pci_iounmap(struct pci_dev *dev, void __iomem *p) >> { >> } >> #endif >> #endif /* CONFIG_GENERIC_IOMAP */ >> >> and CONFIG_GENERIC_IOMAP is not defined when I do allmodconfig with >> avr32. I have not seen this earlier, maybe in my patch pci_iounmap() was >> not required. But pci_iomap is declared as extern so we need have it >> somewhere. > Hi Hans, > Please suggest. I can ack the original change, but it will only lead to a cluttered code base. The real problem is somewhere else, where it looks like the CONFIG_GENERIC_IOMAP symbol assumes PCI is for everybody. I would like if somebody addressed that problem instead. -- Hans-Christian Egtvedt