From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754011AbbI1Xx2 (ORCPT ); Mon, 28 Sep 2015 19:53:28 -0400 Received: from mail-bn1on0146.outbound.protection.outlook.com ([157.56.110.146]:25885 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752984AbbI1Xx0 (ORCPT ); Mon, 28 Sep 2015 19:53:26 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Date: Mon, 28 Sep 2015 18:53:17 -0500 From: Scott Wood To: Christophe Leroy CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , , Subject: Re: [PATCH v2 08/25] powerpc/8xx: Map IMMR area with 512k page at a fixed address Message-ID: <20150928235317.GE6161@home.buserror.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [2601:448:8100:f9f:50d6:efef:9d58:181b] X-ClientProxiedBy: BLUPR11CA0011.namprd11.prod.outlook.com (10.141.240.21) To BN3PR03MB1477.namprd03.prod.outlook.com (25.163.35.140) X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1477;2:/YbHXGamDHgz4EHbomiQ9LPdD9m4rEUDbwAA5EpD3hMdbTFHCbQ3ZHcNKgaLp2mzfmLglpNEgpPN/mLdbGIM/VH2tfo6dPosFHbwiiY9aGbcg0zrS2yewmsRLVHOuQQZDGbOuR5LIkX85KTE3Idu1uDpr9RLNX9PwUiVdjNNQfI=;3:j6gnDUOVCFiHiVHohArEhboo6Ky3DyJL8nb9qxxK7uXTJMVuTIs74i0cN+CWdKE4YIzni2setN6UKen0nQ6ZiqbjMEDRCEJ2X5UzfbAH7MxvBrrbkMUsqi0thD5zReUdo7DJDO/MRkqga60hI75v6g==;25:cqyTtssx+hbtzwQt+Bw63HaNr6Pb+S8MKvPUFOE5HhZulb6OajSWW8bJHmogE6arK//xxqVXctHXR8fEbocnJo49XOuDX8yrrFfh1BwmtKPJqCUBaG0AoXD474TX/usuQDWj/3S550feIawU+BtsUtRmQ/EwVwYD0d1hZ6ixIWR/oWgtbvG2nZ8h86/jt9kAIG9pMt5fkeHwZ00zAEd4qiMC1DD3Q5ZgSTWFYQEL1e8rv/wkQKZx9VpBZl1BTctDUzeRIDSwW0p+K9uuQWhPVQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1477; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1477;20:WsUFqofrOgLCngrQIzFbxqlEGe6Jb8LoDndas8Q6Hd8uvsMask8HgRKTKSpUh8vlubZHK2uT9pUeVPmzYEexT4t1b1+bThPsbXWWgEuJ0V8U6EPW6XtWPMBd4UDhFLTu7+/bWB5j3OIaGxTyunrmLB3W01mT7h7vVxrR0Ml1b3q0/DedvvcYl9KmM69UOXRfphGlrEYr4jPlx2vWekuRQmkMlR7b5KGbeRRHc027jmwDwGljox1D3f/QS/us6S7uUaNznNhCQgWs5qJoPX6NUB5t0rehU/upFKJblbSGYIDsIwYjnHyhB51Vrd+TcbOrLohQ+DAgABIuPtmrSOtui0pIco3DY5j4f4lRzTjuEHo81QkgYeprx5X97n379VjQIQTja1eMx5p4rAyZFQHmaHZJwcrhsEpCrcRwCzRHXpgYd18JGHgb2+ecJ3JErp/hYZsb7uPOvx7lEk1so9QoUdNbSMCsz5phIXkLv5hF1HpLa2cO0g5XwBP2D47WFEuJ;4:1WKYpKPjb2tt0EsT81HFK3UOai93UNGmejKDeAT+yYuZG6mTBzuOr4LSZZJn48bTHYlBifSm10su90lo114lX1lX9pUQKgpgwMLNHzvGOJnx52gpE4rWBJy77XwOkNE56hAHRkWlyW3sAGX/xL7akZhJIZMSB0cw2YixmMr0cjB7cRZi+pbXdLxO+BfusNBGOt3OD255YGfoCMEt46dp2jn9kt0wGXbsgiO/zPi2qAqtqrr6prhDT+pRd2xWLbiI26Iiw8LQtdgw+4XuO9ckUBrOgCXnVe9/oTJZ7N1lVZYbHSPVOmNGmn6Ic2VqcXIP7iDd3AopRx3ssKCqHJTFyj/nw1HOwMM9kQZfCONSwa4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:BN3PR03MB1477;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1477; X-Forefront-PRVS: 0713BC207F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(24454002)(189002)(77156002)(189998001)(86362001)(97756001)(5001960100002)(42186005)(92566002)(53416004)(5004730100002)(83506001)(81156007)(5007970100001)(110136002)(87976001)(76176999)(46102003)(122386002)(106356001)(2950100001)(40100003)(50466002)(54356999)(105586002)(50986999)(101416001)(62966003)(69596002)(5001830100001)(77096005)(23726002)(33656002)(4001540100001)(97736004)(47776003)(5001860100001)(4001350100001)(68736005)(64706001)(46406003)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR03MB1477;H:home.buserror.net;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR03MB1477;23:CGh1xaMg3GdL6r/xqzO8HipytGje/mz6Mtisqxu+t?= =?us-ascii?Q?eEpoACX4fZIpCgSDRW1e0IVjiDshFQqwwYN9zLD6xOBAUAjkFe0BeyGcc/Uc?= =?us-ascii?Q?/iXeJ+btkqJ5Mv2nBc6WjvwQXKcGUuC3KbGB0d3DrpqhaJltit6+BisVbA1f?= =?us-ascii?Q?G41uw9oeCRELDx3a4JSi5pGu0Fz44R3N5AAZoGsOrnlcEBAArj39puUl0/Vt?= =?us-ascii?Q?8D58Dao3VSVYsTs1P32Gtff9LCwVr7yXSPfi+fBIUmTVM2/t7eAI/zs3Wbsd?= =?us-ascii?Q?PFR1BWzUxmBPT8/oee1GMtkKGGQQCG/84ETo33/HVzAjbQnlyTU7wTZFO0Nc?= =?us-ascii?Q?EN4Vxy+H0XbwbtO6r3VHPgAokrQreEZ+LBs1r9LpGSW58/joTQMyO/KNRgoo?= =?us-ascii?Q?eJEHKE4fWRX35j2Ol23o81D6v3cKZcczY7GV3jb2QXX95Lw+Lo2BhiTztmoj?= =?us-ascii?Q?GrRSu+K4AhJuLK6hCkf/j5qBDDYeU68JAx0+oEDPOUlNeNYJSMbOYvPdo9el?= =?us-ascii?Q?WA+mGNxVhqyDrtoTDQBLZJ1jqIpGDsfb0nsFrifSgmVbTTAuQB0yY1Smus6A?= =?us-ascii?Q?kSuaJBv6+sb8NFQvhLBwKSdu3P87q5ZkYd2jOHppSHXLyByR+xhT6oB7U8Ub?= =?us-ascii?Q?FtACODivynGfcduZCB9tQxqMO6fUetbkjaIlrDmv61HsX6F+ElX8FGygDRAj?= =?us-ascii?Q?isAyI/1iVElXTsu4Wq/3D5Bao2zC09GmShkPYVzPG32jzmQvcyY1vZfbKjRD?= =?us-ascii?Q?Q9cjXVuHXBBVEMVMOGkNDiNluLUVcf5x80VFhWXWzrYOOpzCd0DLEJkjOTv0?= =?us-ascii?Q?TZq6aNWV9nlDaO9z5DjMvCFzKXtAUvZX8LwecQlhE7NmorzypZ+ETYNnHw3H?= =?us-ascii?Q?RO8dOWdScF4Xv5/s8VF7sEEArMwmHYCNSkfRDtCIOMY/tkfeL7IwXDKAn8FU?= =?us-ascii?Q?b4iuL3N7aSdOV9kaNzG3BMGowUHY65wgFVuIg6SoDRb2BuG6QcA34qoancd1?= =?us-ascii?Q?YENV7ORSbFq77rgxeMnugxqJqfLwEIu45cYagc8W9WIsbHi0cdv6RCPq4oA9?= =?us-ascii?Q?zeldNzAYG0UCAtqe1ylbmcjPvKZc6hjTLczQZ566iseZZsuPg09t3LbNBCaW?= =?us-ascii?Q?HV1DYgyRlothCQoMwbqGxQ6+ALDrRY3HjoTlZfY0jHfVr3CFMoBCVNiABTBr?= =?us-ascii?Q?UwoKiROlUXvA60=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1477;5:nPWx+CJAyrZZnODjT6m4mnUgRh/MdrnQchIK3SjQf8OvvHKg4Fz6JMsN8mUwuffmmDV2iWUZZ2elXDvqPhkMHO/A4yq5JUajs8MZj+ROL7n+s6bLTMbnuhj2459A1Vym/tbeWpVWQD7m+JNeQBRlDg==;24:6B7x5zN2Z5E+6KnkFcevnEhrakDCgHCVz1Hg4/Fue4JHTupijIgXSHRXJYqw6fsPzJDLtJgAAsEB/KWWg6RntLJ7PkfyHl70kDfNP/RZZE0=;20:WfdcPceRkzVdISi1IKNMtYhjY1TpcsNYFaC5PBDNgVuW2BgpyzI12MLhkeMNSDCBh7tdVqe23SIG7dUjVd+Erg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2015 23:53:24.1070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1477 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2015 at 06:50:44PM +0200, Christophe Leroy wrote: > diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c > index 3fd9083..1f2fdbc 100644 > --- a/arch/powerpc/mm/pgtable_32.c > +++ b/arch/powerpc/mm/pgtable_32.c > @@ -49,6 +49,10 @@ EXPORT_SYMBOL(ioremap_bot); /* aka VMALLOC_END */ > #define HAVE_TLBCAM 1 > #endif > > +#if CONFIG_PPC_8xx > +#define HAVE_LTLB 1 > +#endif > + > extern char etext[], _stext[]; > > #ifdef HAVE_BATS > @@ -67,6 +71,14 @@ extern unsigned long p_mapped_by_tlbcam(phys_addr_t pa); > #define p_mapped_by_tlbcam(x) (0UL) > #endif /* HAVE_TLBCAM */ > > +#ifdef HAVE_LTLB > +phys_addr_t v_mapped_by_ltlb(unsigned long va); > +unsigned long p_mapped_by_ltlb(phys_addr_t pa); > +#else /* !HAVE_LTLB */ > +#define v_mapped_by_ltlb(x) (0UL) > +#define p_mapped_by_ltlb(x) (0UL) > +#endif /* HAVE_LTLB */ > + > static inline unsigned long p_mapped_by_other(phys_addr_t pa) > { > unsigned long v; > @@ -75,6 +87,10 @@ static inline unsigned long p_mapped_by_other(phys_addr_t pa) > if (v /*&& p_mapped_by_bats(p+size-1)*/) > return v; > > + v = p_mapped_by_ltlb(pa); > + if (v) > + return v; > + > return p_mapped_by_tlbcam(pa); > } > > @@ -86,6 +102,10 @@ static inline phys_addr_t v_mapped_by_other(unsigned long va) > if (p) > return p; > > + p = v_mapped_by_ltlb(va); > + if (p) > + return p; > + > return v_mapped_by_tlbcam(va); > } Since there is no kernel with more than one of {bats,ltlb,tlbcam} can we just call it *_block_mapped() and have each subarch provide its implementation (or stub) thereof? -Scott