From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753117AbbI3PMp (ORCPT ); Wed, 30 Sep 2015 11:12:45 -0400 Received: from outbound-smtp01.blacknight.com ([81.17.249.7]:37986 "EHLO outbound-smtp01.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbbI3PMm (ORCPT ); Wed, 30 Sep 2015 11:12:42 -0400 Date: Wed, 30 Sep 2015 16:12:34 +0100 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , Johannes Weiner , Rik van Riel , David Rientjes , Joonsoo Kim , Michal Hocko , Linux-MM , LKML Subject: Re: [PATCH 10/10] mm, page_alloc: Only enforce watermarks for order-0 allocations Message-ID: <20150930151234.GP3068@techsingularity.net> References: <1442832762-7247-1-git-send-email-mgorman@techsingularity.net> <20150921120317.GC3068@techsingularity.net> <20150929140507.82b5e02f300038e4bb5b2493@linux-foundation.org> <20150930084650.GM3068@techsingularity.net> <560BEF08.60704@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <560BEF08.60704@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 04:17:44PM +0200, Vlastimil Babka wrote: > >--- > > mm/page_alloc.c | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > >diff --git a/mm/page_alloc.c b/mm/page_alloc.c > >index 25731624d734..fedec98aafca 100644 > >--- a/mm/page_alloc.c > >+++ b/mm/page_alloc.c > >@@ -2332,7 +2332,7 @@ static bool __zone_watermark_ok(struct zone *z, unsigned int order, > > { > > long min = mark; > > int o; > >- const bool alloc_harder = (alloc_flags & ALLOC_HARDER); > >+ const int alloc_harder = (alloc_flags & ALLOC_HARDER); > > How bout the !!(alloc_flags & ALLOC_HARDER) conversion to bool? Unless it > forces to make the compiler some extra work... > Some people frown upon that trick as being obscure when it's not unnecessary and a modern compiler is meant to get it right. The int is clear and obvious in this context so I just went with it. -- Mel Gorman SUSE Labs