From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754168AbbJAPu1 (ORCPT ); Thu, 1 Oct 2015 11:50:27 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:60200 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbbJAPuY (ORCPT ); Thu, 1 Oct 2015 11:50:24 -0400 Date: Thu, 1 Oct 2015 10:50:18 -0500 From: Felipe Balbi To: Marek Szyprowski CC: , , , Robert Baldyga , John Youn , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c Message-ID: <20151001155018.GC4469@saruman.tx.rr.com> Reply-To: References: <1442830572-6765-1-git-send-email-m.szyprowski@samsung.com> <1442830572-6765-5-git-send-email-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4jXrM3lyYWu4nBt5" Content-Disposition: inline In-Reply-To: <1442830572-6765-5-git-send-email-m.szyprowski@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4jXrM3lyYWu4nBt5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2015 at 12:16:12PM +0200, Marek Szyprowski wrote: > DWC2 module on some platforms needs three additional hardware > resources: phy controller, clock and power supply. All of them must be > enabled/activated to properly initialize and operate. This was initially > handled in s3c-hsotg driver, which has been converted to 'gadget' part > of dwc2 driver. Unfortunately, not all of this code got moved to common > platform code, what resulted in accessing DWC2 registers without > enabling low-level hardware resources. This fails for example on Exynos > SoCs. This patch moves all the code for managing those resources to > common platform.c file and provides convenient wrappers for controlling > them. >=20 > Signed-off-by: Marek Szyprowski I just caught several build errors which this patch. I hope you can send me a follow-up fix (which I can amend to $subject) otherwise I'll have to drop this series --=20 balbi --4jXrM3lyYWu4nBt5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWDVY6AAoJEIaOsuA1yqREduEP/22DXd/hbx2oAI8q8ewO2An+ ElSetPdJaAM69voOg3Lp2o9dHHB7N/Yv33/TdGPKWadjnMewSi0KRn5CRw8mmIuN OmQ/L6kJjKZ5inl36PuyiTDnKcw1Wm3o6axcftGqeccjIZEr7v4TT1JBw9GRBcD3 GHZ5KhQ5OzDcIf88qwzZWZyfqA0YVVB6jApjy7Dr9rqNTSMKgVyNVCAqN8+/3mQY YYMGHuFY2wXiQOEpQc9ApYXclO2NXp1hUvqqlsSgpo+GWIlCnbRDaY87x+n718v6 LuY1s+52mI2Z8IYD33Q4dQS/U5YUMtt0pA1eUPsCisP2flsLNuaqw4j6uPPh/QRe X+mbTsjuk5bTVQVfidlgK492hhyTbMp1KeDrLYMk6xlsWsGqoaY4I3ayUKsO0fUm vcg6NIhjJZpUuVTiIxC7PqA1zvWMMnZILW0Lbp/KVngLPtXy3yzvOJjC331+YI/T +ZUQJVOig8l1SoFAZVSxRm/6rxEFVoX6XsucDxkpvxtHP+JcgSC5HI6G6tnkfHC8 Kxxf2B8hTN6QjCKk/u0klKZeZClbNBOesVcqKX/ySrmz/yAgzcy2iVpemP4f9aWF ogfikS41v8lgIsHA6hJat0B5dre4184Y69R3qKuV6JagRZ8ia17kqqNpC7uGMK9T NAkhzltPTGeSgICdPPDp =wRYq -----END PGP SIGNATURE----- --4jXrM3lyYWu4nBt5--