From: Felipe Balbi <balbi@ti.com>
To: John Youn <John.Youn@synopsys.com>
Cc: "balbi@ti.com" <balbi@ti.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Robert Baldyga <r.baldyga@samsung.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c
Date: Thu, 1 Oct 2015 17:31:27 -0500 [thread overview]
Message-ID: <20151001223127.GE32355@saruman.tx.rr.com> (raw)
In-Reply-To: <2B3535C5ECE8B5419E3ECBE30077290901DC383EFF@US01WEMBX2.internal.synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 1918 bytes --]
On Thu, Oct 01, 2015 at 10:21:22PM +0000, John Youn wrote:
> On 10/1/2015 3:04 PM, Felipe Balbi wrote:
> > On Thu, Oct 01, 2015 at 09:04:59PM +0000, John Youn wrote:
> >> On 10/1/2015 8:50 AM, Felipe Balbi wrote:
> >>> On Mon, Sep 21, 2015 at 12:16:12PM +0200, Marek Szyprowski wrote:
> >>>> DWC2 module on some platforms needs three additional hardware
> >>>> resources: phy controller, clock and power supply. All of them must be
> >>>> enabled/activated to properly initialize and operate. This was initially
> >>>> handled in s3c-hsotg driver, which has been converted to 'gadget' part
> >>>> of dwc2 driver. Unfortunately, not all of this code got moved to common
> >>>> platform code, what resulted in accessing DWC2 registers without
> >>>> enabling low-level hardware resources. This fails for example on Exynos
> >>>> SoCs. This patch moves all the code for managing those resources to
> >>>> common platform.c file and provides convenient wrappers for controlling
> >>>> them.
> >>>>
> >>>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> >>>
> >>> I just caught several build errors which this patch. I hope you can
> >>> send me a follow-up fix (which I can amend to $subject) otherwise
> >>> I'll have to drop this series
> >>>
> >>
> >> I forgot that this was initially part of a larger
> >> patch-set. Maybe that is causing issues? If this wasn't intended
> >> to go through Felipe's tree then my bad.
> >>
> >> Also, I noticed this patch causes deadlock warnings with lockdep
> >> enabled.
> >>
> >> Can you look into that also while you investigate this?
> >
> > John, do you want me to drop the series meanwhile ? I can do that no problems.
> >
>
> You can drop this one. I think leaving in patch 1-3 is fine as
> they are small cleanup patches. Unless you or Marek prefer to
> drop all of them.
dropped this one for now. Thanks
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-01 22:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 10:16 [PATCH v3 0/4] Exynos4412-based Trats2 USB gadget (DWC2) fixes Marek Szyprowski
2015-09-21 10:16 ` [PATCH v3 1/4] usb: dwc2: remove double call to dwc2_hsotg_of_probe Marek Szyprowski
2015-09-21 10:16 ` [PATCH v3 2/4] usb: dwc2: remove non-functional clock gating Marek Szyprowski
2015-09-21 10:16 ` [PATCH v3 3/4] usb: dwc2: fix unbalanced phy control Marek Szyprowski
2015-09-21 10:16 ` [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c Marek Szyprowski
2015-10-01 15:50 ` Felipe Balbi
2015-10-01 15:59 ` Felipe Balbi
2015-10-02 7:45 ` [PATCH v4 " Marek Szyprowski
2015-10-05 22:26 ` John Youn
2015-10-05 23:27 ` Felipe Balbi
2015-10-06 8:55 ` [PATCH v5 1/2] usb: dwc2: remove no longer needed init_mutex Marek Szyprowski
2015-10-06 8:55 ` [PATCH v5 2/2] usb: dwc2: refactor common low-level hw code to platform.c Marek Szyprowski
2015-10-07 2:37 ` John Youn
2015-10-14 6:52 ` [PATCH v6 1/2] usb: dwc2: remove no longer needed init_mutex Marek Szyprowski
2015-10-14 6:52 ` [PATCH v6 2/2] usb: dwc2: refactor common low-level hw code to platform.c Marek Szyprowski
2015-10-06 8:55 ` [PATCH v4 4/4] " Marek Szyprowski
2015-10-01 21:04 ` [PATCH v3 " John Youn
2015-10-01 22:03 ` Felipe Balbi
2015-10-01 22:21 ` John Youn
2015-10-01 22:31 ` Felipe Balbi [this message]
2015-10-02 7:47 ` Marek Szyprowski
2015-09-28 18:21 ` [PATCH v3 0/4] Exynos4412-based Trats2 USB gadget (DWC2) fixes John Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001223127.GE32355@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=John.Youn@synopsys.com \
--cc=b.zolnierkie@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).