From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753701AbbJBSKq (ORCPT ); Fri, 2 Oct 2015 14:10:46 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59763 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753600AbbJBSKo (ORCPT ); Fri, 2 Oct 2015 14:10:44 -0400 Date: Fri, 2 Oct 2015 11:10:42 -0700 From: Stephen Boyd To: Mike Looijmans Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Add driver for the si514 clock generator chip Message-ID: <20151002181042.GL12338@codeaurora.org> References: <1442478495-23522-1-git-send-email-mike.looijmans@topic.nl> <1442487891-20477-1-git-send-email-mike.looijmans@topic.nl> <20151001233407.GW19319@codeaurora.org> <560E1DF6.9010901@topic.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <560E1DF6.9010901@topic.nl> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02, Mike Looijmans wrote: > On 02-10-15 01:34, Stephen Boyd wrote: > >>+ - clock-output-names: From common clock bindings. Recommended to be "si514". > >>+ - clock-frequency: Output frequency to generate. This defines the output > >>+ frequency set during boot. It can be reprogrammed during > >>+ runtime through the common clock framework. > > > >Can we use assigned clock rates instead of this property? > > I'll first need to learn what 'assigned clock rates' means. But I > suspect the answer will be yes. See the "Assigned clock parents and rates" section of Documentation/devicetree/bindings/clock/clock-bindings.txt and commit 86be408bfbd8 (clk: Support for clock parents and rates assigned from device tree, 2014-06-18). > > >>+ > >>+Example: > >>+ si514: clock-generator@55 { > >>+ reg = <0x55>; > >>+ #clock-cells = <0>; > >>+ compatible = "silabs,si514"; > >>+ }; > >>diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > >>index 42f7120..6ac7deb5 100644 > >>--- a/drivers/clk/Kconfig > >>+++ b/drivers/clk/Kconfig > >>@@ -68,6 +68,16 @@ config COMMON_CLK_SI5351 > >> This driver supports Silicon Labs 5351A/B/C programmable clock > >> generators. > >> > >>+config COMMON_CLK_SI514 > >>+ tristate "Clock driver for SiLabs 514 devices" > >>+ depends on I2C > >>+ depends on OF > > > >It actually depends on this to build? > > It calls various 'of_' methods unconditionally, so I'd think so. Aren't there stubs for those if CONFIG_OF=n? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project