From: Marc Zyngier <marc.zyngier@arm.com>
To: Wei Huang <wei@redhat.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Hanjun Guo <hanjun.guo@linaro.org>,
Tomasz Nowicki <tomasz.nowicki@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
<linaro-acpi@lists.linaro.org>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/7] acpi: Add early device probing infrastructure
Date: Sat, 3 Oct 2015 11:04:02 +0100 [thread overview]
Message-ID: <20151003110402.6aa3022b@arm.com> (raw)
In-Reply-To: <560EF1BD.1020004@redhat.com>
On Fri, 2 Oct 2015 16:06:05 -0500
Wei Huang <wei@redhat.com> wrote:
Hi Wei,
> Hi Marc,
[...]
> > +struct acpi_probe_entry {
> > + __u8 id[ACPI_TABLE_ID_LEN];
> > + __u8 type;
> > + acpi_probe_entry_validate_subtbl subtable_valid;
> > + union {
> > + acpi_tbl_table_handler probe_table;
> > + acpi_tbl_entry_handler probe_subtbl;
> > + };
>
> Could we avoid using union for probe_table & probe_subtbl? The benefit is that we don't need to do function casting below and compiler can automatically check the correctness.
>
> > + kernel_ulong_t driver_data;
> > +};
> > +
> > +#define ACPI_DECLARE_PROBE_ENTRY(table, name, table_id, subtable, valid, data, fn) \
> > + static const struct acpi_probe_entry __acpi_probe_##name \
> > + __used __section(__##table##_acpi_probe_table) \
> > + = { \
> > + .id = table_id, \
> > + .type = subtable, \
> > + .subtable_valid = valid, \
> > + .probe_table = (acpi_tbl_table_handler)fn, \
> > + .driver_data = data, \
> > + }
> > +
>
> Something like:
>
> #define ACPI_DECLARE_PROBE_ENTRY(table, name, table_id, subtable, valid, data, fn, subfn) \
> static const struct acpi_probe_entry __acpi_probe_##name \
> __used __section(__##table##_acpi_probe_table) \
> = { \
> .id = table_id, \
> .type = subtable, \
> .subtable_valid = valid, \
> .probe_table = fn, \
> .probe_subtbl = subfn, \
> .driver_data = data, \
> }
>
> Then in patch 3, you can define new entries as:
>
> IRQCHIP_ACPI_DECLARE(gic_v2, ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR,
> gic_validate_dist, ACPI_MADT_GIC_VERSION_V2,
> NULL, gic_v2_acpi_init);
> IRQCHIP_ACPI_DECLARE(gic_v2_maybe, ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR,
> gic_validate_dist, ACPI_MADT_GIC_VERSION_NONE,
> NULL, gic_v2_acpi_init);
>
That's exactly what I was trying to avoid. If you want to do that, do
it in the IRQCHIP_ACPI_DECLARE macro, as there is strictly no need for
this this NULL to appear here (MADT always matches by subtable).
Or even better, have two ACPI_DECLARE* that populate the probe entry in
a mutually exclusive way (either probe_table is set and both
valid/subtbl are NULL, or probe_table is NULL and the two other fields
are set).
Thanks,
M.
--
Jazz is not dead. It just smells funny.
next prev parent reply other threads:[~2015-10-03 10:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 14:49 [PATCH v3 0/7] Early ACPI probing infrastructure Marc Zyngier
2015-09-28 14:49 ` [PATCH v3 1/7] acpi: Add early device " Marc Zyngier
2015-09-29 4:30 ` Daniel Lezcano
2015-09-29 7:29 ` Marc Zyngier
2015-09-29 12:17 ` Daniel Lezcano
2015-09-29 11:05 ` Lorenzo Pieralisi
2015-09-29 14:41 ` Hanjun Guo
2015-10-02 21:06 ` Wei Huang
2015-10-03 10:04 ` Marc Zyngier [this message]
2015-10-05 17:07 ` Wei Huang
2015-09-28 14:49 ` [PATCH v3 2/7] irqchip/acpi: Add probing infrastructure for ACPI-based irqchips Marc Zyngier
2015-09-29 10:19 ` Catalin Marinas
2015-09-29 14:42 ` Hanjun Guo
2015-09-28 14:49 ` [PATCH v3 3/7] irqchip/gic: Convert the GIC driver to ACPI probing Marc Zyngier
2015-09-29 10:20 ` Catalin Marinas
2015-09-29 15:01 ` Hanjun Guo
2015-09-28 14:49 ` [PATCH v3 4/7] clocksource/acpi: Add probing infrastructure for ACPI-based clocksources Marc Zyngier
2015-09-28 14:49 ` [PATCH v3 5/7] clocksource: Add new CLKSRC_{PROBE,ACPI} config symbols Marc Zyngier
2015-09-28 14:49 ` [PATCH v3 6/7] clocksource/arm_arch_timer: Convert to ACPI probing Marc Zyngier
2015-09-29 10:26 ` Catalin Marinas
2015-09-28 14:49 ` [PATCH v3 7/7] clocksource: cosmetic: Drop OF 'dependency' from symbols Marc Zyngier
2015-09-29 10:27 ` Catalin Marinas
2015-09-29 15:14 ` Hanjun Guo
2015-09-28 22:46 ` [PATCH v3 0/7] Early ACPI probing infrastructure Rafael J. Wysocki
2015-09-30 10:44 ` Thomas Gleixner
2015-10-05 13:37 ` Rafael J. Wysocki
2015-09-29 15:25 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151003110402.6aa3022b@arm.com \
--to=marc.zyngier@arm.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=jason@lakedaemon.net \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=tomasz.nowicki@linaro.org \
--cc=wei@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).