From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752104AbbJCL1J (ORCPT <rfc822;w@1wt.eu>);
	Sat, 3 Oct 2015 07:27:09 -0400
Received: from mail-wi0-f173.google.com ([209.85.212.173]:37203 "EHLO
	mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752022AbbJCL1H (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 3 Oct 2015 07:27:07 -0400
Date: Sat, 3 Oct 2015 13:27:01 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, keescook@chromium.org
Subject: Re: [PATCH v2] x86/mm: warn on W+x mappings
Message-ID: <20151003112701.GA4531@gmail.com>
References: <1443814185-21552-1-git-send-email-sds@tycho.nsa.gov>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443814185-21552-1-git-send-email-sds@tycho.nsa.gov>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Stephen Smalley <sds@tycho.nsa.gov> wrote:

> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> index 30564e2..f8b1573 100644
> --- a/arch/x86/mm/init_64.c
> +++ b/arch/x86/mm/init_64.c
> @@ -1150,6 +1150,8 @@ void mark_rodata_ro(void)
>  	free_init_pages("unused kernel",
>  			(unsigned long) __va(__pa_symbol(rodata_end)),
>  			(unsigned long) __va(__pa_symbol(_sdata)));
> +
> +	debug_checkwx();

Any reason to not do this on NX capable 32-bit kernels as well?

Thanks,

	Ingo