From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751506AbbJDLTO (ORCPT ); Sun, 4 Oct 2015 07:19:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40621 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbbJDLTN (ORCPT ); Sun, 4 Oct 2015 07:19:13 -0400 Date: Sun, 4 Oct 2015 12:19:06 +0100 From: Greg Kroah-Hartman To: Tomas Winkler Cc: Alexander Usyskin , linux-kernel@vger.kernel.org, Alexander Kuleshov Subject: Re: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output Message-ID: <20151004111906.GA23333@kroah.com> References: <1442822295-5111-1-git-send-email-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442822295-5111-1-git-send-email-tomas.winkler@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 10:58:15AM +0300, Tomas Winkler wrote: > From: Alexander Kuleshov > > Signed-off-by: Alexander Kuleshov > Signed-off-by: Tomas Winkler > --- > V2: fixed author address > > drivers/misc/mei/debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c > index 4b469cf9e60f..c157f0ba575c 100644 > --- a/drivers/misc/mei/debugfs.c > +++ b/drivers/misc/mei/debugfs.c > @@ -213,7 +213,7 @@ int mei_dbgfs_register(struct mei_device *dev, const char *name) > f = debugfs_create_file("active", S_IRUSR, dir, > dev, &mei_dbgfs_fops_active); > if (!f) { > - dev_err(dev->dev, "meclients: registration failed\n"); > + dev_err(dev->dev, "active: registration failed\n"); > goto err; You should never care if a debugfs call fails or not. Also, this will "fail" if you don't have CONFIG_DEBUGFS enabled, which means you are using the api wrong :( greg k-h