From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbbJDSdm (ORCPT ); Sun, 4 Oct 2015 14:33:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42582 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453AbbJDSdk (ORCPT ); Sun, 4 Oct 2015 14:33:40 -0400 Date: Sun, 4 Oct 2015 19:33:34 +0100 From: Greg KH To: Emilio =?iso-8859-1?Q?L=F3pez?= Cc: olof@lixom.net, kgene@kernel.org, k.kozlowski@samsung.com, linux@roeck-us.net, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 1/4] sysfs: Support is_visible() on binary attributes Message-ID: <20151004183334.GA23538@kroah.com> References: <1442842703-5309-1-git-send-email-emilio.lopez@collabora.co.uk> <1442842703-5309-2-git-send-email-emilio.lopez@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1442842703-5309-2-git-send-email-emilio.lopez@collabora.co.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2015 at 10:38:20AM -0300, Emilio López wrote: > According to the sysfs header file: > > "The returned value will replace static permissions defined in > struct attribute or struct bin_attribute." > > but this isn't the case, as is_visible is only called on struct attribute > only. This patch introduces a new is_bin_visible() function to implement > the same functionality for binary attributes, and updates documentation > accordingly. > > Note that to keep functionality and code similar to that of normal > attributes, the mode is now checked as well to ensure it contains only > read/write permissions or SYSFS_PREALLOC. > > Reviewed-by: Guenter Roeck > Signed-off-by: Emilio López As this should probably go through the "platform drivers" maintainer, I'll just give you this: Acked-by: Greg Kroah-Hartman So it can go through their tree and not require me to just take this one. thanks, greg k-h