From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751866AbbJDTQJ (ORCPT ); Sun, 4 Oct 2015 15:16:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51245 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbbJDTQH (ORCPT ); Sun, 4 Oct 2015 15:16:07 -0400 Date: Sun, 4 Oct 2015 20:16:02 +0100 From: Greg KH To: "Luis R. Rodriguez" Cc: ming.lei@canonical.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dwmw2@infradead.org, dhowells@redhat.com, seth.forshee@canonical.com, rusty@rustcorp.com.au, mmarek@suse.cz, mjg59@srcf.ucam.org, kyle@kernel.org, linux-security-module@vger.kernel.org, keyrings@linux-nfs.org, "Luis R. Rodriguez" , Andrew Morton , Kees Cook , Casey Schaufler , Takashi Iwai , =?utf-8?Q?Vojt=C4=9Bch_Pavl=C3=ADk?= Subject: Re: [PATCH 1/4] firmware: generalize "firmware" as "system data" helpers Message-ID: <20151004191602.GC9649@kroah.com> References: <1438725604-22795-1-git-send-email-mcgrof@do-not-panic.com> <1438725604-22795-2-git-send-email-mcgrof@do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438725604-22795-2-git-send-email-mcgrof@do-not-panic.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 04, 2015 at 03:00:01PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Historically firmware_class code was added to help > get device driver firmware binaries but these days > request_firmware*() helpers are being repurposed for > general system data needed by the kernel. > > Annotate this before we extend firmare_class more, > as this is expected. We want to generalize the code > as much as possible. No, let's leave this as "firmware", as that is what the code does. If you want to create a "load a resource from the filesystem into the kernel" subsystem, then let's do that and then port the firmware loader code over to use that api. But until then, let's not try to morph the firmware code into something that it really is not at all at the moment, just because it looks like this might be a nice thing to do someday in the future. sorry, greg k-h