From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752879AbbJEKPL (ORCPT ); Mon, 5 Oct 2015 06:15:11 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38831 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752681AbbJEKOo (ORCPT ); Mon, 5 Oct 2015 06:14:44 -0400 Date: Mon, 05 Oct 2015 03:30:24 -0700 (PDT) Message-Id: <20151005.033024.2236659260552514725.davem@davemloft.net> To: santosh.shilimkar@oracle.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, ssantosh@kernel.org Subject: Re: [PATCH v2 05/14] RDS: defer the over_batch work to send worker From: David Miller In-Reply-To: <1443633873-13359-6-git-send-email-santosh.shilimkar@oracle.com> References: <1443633873-13359-1-git-send-email-santosh.shilimkar@oracle.com> <1443633873-13359-6-git-send-email-santosh.shilimkar@oracle.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Oct 2015 03:14:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Santosh Shilimkar Date: Wed, 30 Sep 2015 13:24:24 -0400 > @@ -423,7 +423,9 @@ over_batch: > !list_empty(&conn->c_send_queue)) && > send_gen == conn->c_send_gen) { > rds_stats_inc(s_send_lock_queue_raced); > - goto restart; > + if (batch_count < 1024) > + goto restart; > + queue_delayed_work(rds_wq, &conn->c_send_w, 1); Sorry, you can't just use a magic number like this. You have to describe, in detail, exactly how this value was choosen, derived, and tested to be effeective and in exactly what environment those tests were done. You must also use a mnenomic for this value rather than a raw magic constant. Thanks.