From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752135AbbJEDD5 (ORCPT ); Sun, 4 Oct 2015 23:03:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34320 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885AbbJEDD4 (ORCPT ); Sun, 4 Oct 2015 23:03:56 -0400 Date: Mon, 5 Oct 2015 04:03:52 +0100 From: Greg KH To: Vlad Zolotarov Cc: linux-kernel@vger.kernel.org, mst@redhat.com, hjk@hansjkoch.de, corbet@lwn.net, bruce.richardson@intel.com, avi@cloudius-systems.com, gleb@cloudius-systems.com, stephen@networkplumber.org, alexander.duyck@gmail.com Subject: Re: [PATCH v3 1/3] uio: add ioctl support Message-ID: <20151005030352.GA27303@kroah.com> References: <1443991398-23761-1-git-send-email-vladz@cloudius-systems.com> <1443991398-23761-2-git-send-email-vladz@cloudius-systems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443991398-23761-2-git-send-email-vladz@cloudius-systems.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 04, 2015 at 11:43:16PM +0300, Vlad Zolotarov wrote: > Signed-off-by: Vlad Zolotarov > --- > drivers/uio/uio.c | 15 +++++++++++++++ > include/linux/uio_driver.h | 3 +++ > 2 files changed, 18 insertions(+) You add an ioctl yet fail to justify _why_ you need/want that ioctl, and you don't document it at all? Come on, you know better than that, no one can take a patch that has no changelog comments at all like this :( Also, I _REALLY_ don't want to add any ioctls to the UIO interface, so you had better have a really compelling argument as to why this is the _ONLY_ way you can solve this unknown problem by using such a horrid thing... thanks, greg k-h