From: Mark Brown <broonie@kernel.org>
To: jon@ringle.org
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Jon Ringle <jringle@gridpoint.com>
Subject: Re: [PATCH 1/2] regmap: only call custom reg_update_bits() if reg is marked volatile
Date: Mon, 5 Oct 2015 15:57:22 +0100 [thread overview]
Message-ID: <20151005145722.GT12635@sirena.org.uk> (raw)
In-Reply-To: <1444051772-20270-1-git-send-email-jon@ringle.org>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Mon, Oct 05, 2015 at 09:29:31AM -0400, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
>
> The only time that it makes sense to call a custom provided reg_update_bits
> function, is the register being updated is one that has volatile bits.
> Otherwise, the normal read/modify/write cycle (where the read is likely to
> be free from the cache) will do just fine. This should keep the reg cache
> intact, since volatile registers won't get cached anyway.
Dave, to be clear please do *not* apply this patch at least for the time
being - I've not reviewed it or the one from Thursday that you applied
this morning.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-05 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 13:29 [PATCH 1/2] regmap: only call custom reg_update_bits() if reg is marked volatile jon
2015-10-05 13:29 ` [PATCH 2/2] net: encx24j600: Simplified regmap_encx24j600_reg_update_bits() jon
2015-10-05 14:57 ` Mark Brown [this message]
2015-10-06 6:29 ` [PATCH 1/2] regmap: only call custom reg_update_bits() if reg is marked volatile David Miller
2015-10-06 10:13 ` Mark Brown
2015-10-06 12:50 ` Jon Ringle
2015-10-06 13:25 ` David Miller
2015-10-06 14:31 ` Mark Brown
2015-10-06 13:26 ` David Miller
2015-10-06 13:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005145722.GT12635@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jon@ringle.org \
--cc=jringle@gridpoint.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).