From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752464AbbJEP0i (ORCPT ); Mon, 5 Oct 2015 11:26:38 -0400 Received: from mga11.intel.com ([192.55.52.93]:43816 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752034AbbJEP0g (ORCPT ); Mon, 5 Oct 2015 11:26:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,639,1437462000"; d="scan'208";a="819765759" Date: Mon, 5 Oct 2015 16:26:30 +0100 From: Vinod Koul To: Kedareswara rao Appana Cc: dan.j.williams@intel.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, moritz.fischer@ettus.com, appanad@xilinx.com, anirudha@xilinx.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9] dmaengine: Add Xilinx AXI Direct Memory Access Engine driver support Message-ID: <20151005152628.GE13501@vkoul-mobl.iind.intel.com> References: <1440432666-10310-1-git-send-email-appanad@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440432666-10310-1-git-send-email-appanad@xilinx.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 24, 2015 at 09:41:06PM +0530, Kedareswara rao Appana wrote: > This is the driver for the AXI Direct Memory Access (AXI DMA) > core, which is a soft Xilinx IP core that provides high- > bandwidth direct memory access between memory and AXI4-Stream > type target peripherals. Okay reviewing this after the other Xilinx driver with very similar name, I am very concerned about code duplication. Both codes seems to be pretty much copy paste and some modifications for IP. In Linux kernel we reuse! Please create common lib for Xilinx drivers to use and have HW diff is two drivers, or manage those with different driver ops Pls justify why we should have two drivers. Looking at code makes me think otherwise -- ~Vinod