From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "Usyskin, Alexander" <alexander.usyskin@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexander Kuleshov <kuleshovmail@gmail.com>
Subject: Re: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output
Date: Mon, 5 Oct 2015 16:30:36 +0100 [thread overview]
Message-ID: <20151005153036.GA16834@kroah.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B3D45F060@hasmsx108.ger.corp.intel.com>
On Mon, Oct 05, 2015 at 02:47:35PM +0000, Winkler, Tomas wrote:
> >
> > On Mon, Sep 21, 2015 at 10:58:15AM +0300, Tomas Winkler wrote:
> > > From: Alexander Kuleshov <kuleshovmail@gmail.com>
> > >
> > > Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > > ---
> > > V2: fixed author address
> > >
> > > drivers/misc/mei/debugfs.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
> > > index 4b469cf9e60f..c157f0ba575c 100644
> > > --- a/drivers/misc/mei/debugfs.c
> > > +++ b/drivers/misc/mei/debugfs.c
> > > @@ -213,7 +213,7 @@ int mei_dbgfs_register(struct mei_device *dev, const
> > char *name)
> > > f = debugfs_create_file("active", S_IRUSR, dir,
> > > dev, &mei_dbgfs_fops_active);
> > > if (!f) {
> > > - dev_err(dev->dev, "meclients: registration failed\n");
> > > + dev_err(dev->dev, "active: registration failed\n");
> > > goto err;
> >
> > You should never care if a debugfs call fails or not.
>
> The system should not be dependent on the debug feature but, it is
> always good to know if there our system is failing
And what can you do if it is "failing"? Really nothing, so there's
nothing to check here.
> Also, this will
> > "fail" if you don't have CONFIG_DEBUGFS enabled, which means you are
> > using the api wrong :(
>
> The whole file is not compiled if CONFIG_DEBUGFS is not set, please see the Makefile
Ok, then you don't need to check anything. Debugfs was created to be
dirt-simple, don't add complexity and "must unwind cleanly" type logic
here where it's not needed at all. That just hurts my sensibilities for
why I made the API the way it is in the first place :)
thanks,
greg k-h
next prev parent reply other threads:[~2015-10-05 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 7:58 [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output Tomas Winkler
2015-10-04 11:19 ` Greg Kroah-Hartman
2015-10-05 14:47 ` Winkler, Tomas
2015-10-05 15:30 ` Greg Kroah-Hartman [this message]
2015-10-06 8:46 ` Winkler, Tomas
2015-10-25 12:45 ` Winkler, Tomas
2015-10-25 16:56 ` 'Greg Kroah-Hartman'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005153036.GA16834@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).