From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752374AbbJEQ1f (ORCPT ); Mon, 5 Oct 2015 12:27:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36978 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbbJEQ1e (ORCPT ); Mon, 5 Oct 2015 12:27:34 -0400 Date: Mon, 5 Oct 2015 18:24:16 +0200 From: Oleg Nesterov To: Chen Gang Cc: Andrew Morton , "kirill.shutemov@linux.intel.com" , "riel@redhat.com" , Michal Hocko , "emunson@akamai.com" , "sasha.levin@oracle.com" , "pfeiner@google.com" , "aarcange@redhat.com" , "vishnu.ps@samsung.com" , Linux Memory , kernel mailing list Subject: Re: [PATCH] mm/mmap.c: Remove redundant statement "error = -ENOMEM" Message-ID: <20151005162416.GA19857@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05, Chen Gang wrote: > > It is still a little better to remove it, although it should be skipped > by "-O2". Agreed, it can confuse the reader. > Signed-off-by: Chen Gang Acked-by: Oleg Nesterov > --- >  mm/mmap.c | 1 - >  1 file changed, 1 deletion(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 8393580..1da4600 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1562,7 +1562,6 @@ unsigned long mmap_region(struct file *file, unsigned long addr, >   } >   >   /* Clear old maps */ > - error = -ENOMEM; >   while (find_vma_links(mm, addr, addr + len, &prev, &rb_link, >        &rb_parent)) { >   if (do_munmap(mm, addr, len)) > --  > 1.9.3 > >