From: Michal Hocko <mhocko@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Kyle Walker <kwalker@redhat.com>,
Stanislav Kozina <skozina@redhat.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] coredump: ensure all coredumping tasks have
Date: Mon, 5 Oct 2015 18:25:38 +0200 [thread overview]
Message-ID: <20151005162538.GE7023@dhcp22.suse.cz> (raw)
In-Reply-To: <20150929155502.GA15109@redhat.com>
The subject is truncated. It is missing SIGNAL_GROUP_COREDUMP
On Tue 29-09-15 17:55:02, Oleg Nesterov wrote:
> task_will_free_mem() is wrong in many ways, and in particular the
> SIGNAL_GROUP_COREDUMP check is not reliable: a task can participate
> in the coredumping without SIGNAL_GROUP_COREDUMP bit set.
>
> change zap_threads() paths to always set SIGNAL_GROUP_COREDUMP even
> if other CLONE_VM processes can't react to SIGKILL. Fortunately, at
> least oom-kill case if fine; it kills all tasks sharing the same mm,
> so it should also kill the process which actually dumps the core.
Yes I do not think it will make too much difference for the oom killer
but it is much better to handle all the processes sharing the mm the
same way.
>
> The change in prepare_signal() is not strictly necessary, it just
> ensures that the patch does not bring another subtle behavioural
> change. But it reminds us that this SIGNAL_GROUP_EXIT/COREDUMP case
> needs more changes.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> fs/coredump.c | 12 ++++++------
> kernel/signal.c | 2 +-
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/fs/coredump.c b/fs/coredump.c
> index 53d7d46..4fed8d0 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -282,11 +282,13 @@ out:
> return ispipe;
> }
>
> -static int zap_process(struct task_struct *start, int exit_code)
> +static int zap_process(struct task_struct *start, int exit_code, int flags)
> {
> struct task_struct *t;
> int nr = 0;
>
> + /* ignore all signals except SIGKILL, see prepare_signal() */
> + start->signal->flags = SIGNAL_GROUP_COREDUMP | flags;
> start->signal->group_exit_code = exit_code;
> start->signal->group_stop_count = 0;
>
> @@ -313,10 +315,8 @@ static int zap_threads(struct task_struct *tsk, struct mm_struct *mm,
> spin_lock_irq(&tsk->sighand->siglock);
> if (!signal_group_exit(tsk->signal)) {
> mm->core_state = core_state;
> - nr = zap_process(tsk, exit_code);
> tsk->signal->group_exit_task = tsk;
> - /* ignore all signals except SIGKILL, see prepare_signal() */
> - tsk->signal->flags = SIGNAL_GROUP_COREDUMP;
> + nr = zap_process(tsk, exit_code, 0);
> clear_tsk_thread_flag(tsk, TIF_SIGPENDING);
> }
> spin_unlock_irq(&tsk->sighand->siglock);
> @@ -367,8 +367,8 @@ static int zap_threads(struct task_struct *tsk, struct mm_struct *mm,
> if (p->mm) {
> if (unlikely(p->mm == mm)) {
> lock_task_sighand(p, &flags);
> - nr += zap_process(p, exit_code);
> - p->signal->flags = SIGNAL_GROUP_EXIT;
> + nr += zap_process(p, exit_code,
> + SIGNAL_GROUP_EXIT);
> unlock_task_sighand(p, &flags);
> }
> break;
> diff --git a/kernel/signal.c b/kernel/signal.c
> index f2cbd4e..c0b01fe 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -788,7 +788,7 @@ static bool prepare_signal(int sig, struct task_struct *p, bool force)
> sigset_t flush;
>
> if (signal->flags & (SIGNAL_GROUP_EXIT | SIGNAL_GROUP_COREDUMP)) {
> - if (signal->flags & SIGNAL_GROUP_COREDUMP)
> + if (!(signal->flags & SIGNAL_GROUP_EXIT))
> return sig == SIGKILL;
> /*
> * The process is in the middle of dying, nothing to do.
> --
> 2.4.3
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2015-10-05 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 15:54 [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to oom-killer Oleg Nesterov
2015-09-29 15:55 ` [PATCH 1/2] coredump: ensure all coredumping tasks have Oleg Nesterov
2015-10-05 16:25 ` Michal Hocko [this message]
2015-09-29 15:55 ` [PATCH 2/2] coredump: change zap_threads() and zap_process() to use Oleg Nesterov
2015-09-30 11:49 ` [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to oom-killer Tetsuo Handa
2015-09-30 14:15 ` Oleg Nesterov
2015-09-30 16:12 ` Tetsuo Handa
2015-09-30 16:40 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005162538.GE7023@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=kwalker@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=skozina@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).