From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
arnd@arndb.de, linux-arch@vger.kernel.org, mingo@kernel.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
linux-s390@vger.kernel.org, bp@suse.de, linux@roeck-us.net,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
rostedt@goodmis.org
Subject: Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit
Date: Mon, 5 Oct 2015 18:58:56 +0200 [thread overview]
Message-ID: <20151005165856.GL14464@wotan.suse.de> (raw)
In-Reply-To: <56106F5C.5060409@infradead.org>
On Sat, Oct 03, 2015 at 05:14:20PM -0700, Randy Dunlap wrote:
> On 10/02/15 16:17, Luis R. Rodriguez wrote:
> > On Fri, Aug 28, 2015 at 07:13:08PM -0700, Randy Dunlap wrote:
> >> On 08/28/15 17:17, Luis R. Rodriguez wrote:
> >>>
> >>> arch/s390/Kconfig | 8 +++++
> >>> arch/s390/include/asm/io.h | 11 -------
> >>> arch/s390/include/asm/pci.h | 2 --
> >>> arch/s390/include/asm/pci_iomap.h | 33 +++++++++++++++++++++
> >>> arch/s390/pci/pci.c | 2 ++
> >>> include/asm-generic/io.h | 12 --------
> >>> include/asm-generic/iomap.h | 10 -------
> >>> include/asm-generic/pci_iomap.h | 62 +++++++++++++++++++++++++++++++++++----
> >>> lib/Kconfig | 1 +
> >>> lib/pci_iomap.c | 5 ++++
> >>> 10 files changed, 105 insertions(+), 41 deletions(-)
> >>> create mode 100644 arch/s390/include/asm/pci_iomap.h
> >>>
> >>> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> >>> index 1d57000b1b24..1217b7db4265 100644
> >>> --- a/arch/s390/Kconfig
> >>> +++ b/arch/s390/Kconfig
> >>> @@ -614,6 +614,14 @@ endif # PCI
> >>> config PCI_DOMAINS
> >>> def_bool PCI
> >>>
> >>> +config ARCH_PCI_NON_DISJUNCTIVE
> >>> + def_bool PCI
> >>> + help
> >>> + On the S390 architecture PCI BAR spaces are not disjunctive, as such
> >>
> >> are not disjoint? may be overlapping?
> >>
> >>> + the PCI bar is required on a series of otherwise asm generic PCI
> >>> + routines, as such S390 requires itw own implemention for these
> >>
> >> its own implementation
> >
> > Thanks, I've re-written this as:
> >
> > mcgrof@ergon ~/linux-next (git::(no branch, rebasing 20150805-pend-all))$ git diff
> > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> > index f4725d1af438..8ba5826ed13b 100644
> > --- a/arch/s390/Kconfig
> > +++ b/arch/s390/Kconfig
> > @@ -618,10 +618,10 @@ config PCI_DOMAINS
> > config ARCH_PCI_NON_DISJUNCTIVE
> > def_bool PCI
> > help
> > - On the S390 architecture PCI BAR spaces are not disjunctive, as such
> > - the PCI bar is required on a series of otherwise asm generic PCI
> > - routines, as such S390 requires itw own implemention for these
> > - routines.
> > + On the S390 architecture PCI BAR spaces may overlap with each other,
>
> That "other," should not end with a comma. Either use a semi-colon or use a
> period and begin the next sentence with Because.
Amended, thanks.
Luis
next prev parent reply other threads:[~2015-10-05 16:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 0:17 [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit Luis R. Rodriguez
2015-08-29 2:13 ` Randy Dunlap
2015-10-02 23:17 ` Luis R. Rodriguez
2015-10-04 0:14 ` Randy Dunlap
2015-10-05 16:58 ` Luis R. Rodriguez [this message]
2015-08-29 15:25 ` Christoph Hellwig
2015-09-03 1:45 ` Luis R. Rodriguez
2015-08-30 19:30 ` Arnd Bergmann
2015-09-03 1:44 ` Luis R. Rodriguez
2015-09-03 1:47 ` Luis R. Rodriguez
2015-09-08 9:54 ` Luis R. Rodriguez
2015-09-08 13:42 ` Arnd Bergmann
2015-09-11 8:14 ` Martin Schwidefsky
2015-10-03 0:04 ` Luis R. Rodriguez
2015-10-02 23:53 ` Luis R. Rodriguez
2015-10-04 19:02 ` Arnd Bergmann
2015-10-05 17:09 ` Luis R. Rodriguez
2015-10-06 11:15 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005165856.GL14464@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mcgrof@do-not-panic.com \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).