From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbbJFJKQ (ORCPT ); Tue, 6 Oct 2015 05:10:16 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:42160 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbbJFJKN (ORCPT ); Tue, 6 Oct 2015 05:10:13 -0400 Date: Tue, 6 Oct 2015 10:09:59 +0100 From: Russell King - ARM Linux To: "Suzuki K. Poulose" Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, Vladimir.Murzin@arm.com, steve.capper@linaro.org, ard.biesheuvel@linaro.org, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, edward.nevill@linaro.org, aph@redhat.com, james.morse@arm.com, andre.przywara@arm.com, dave.martin@arm.com Subject: Re: [PATCH v2 21/22] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to sysfs Message-ID: <20151006090959.GO21513@n2100.arm.linux.org.uk> References: <1444064531-25607-1-git-send-email-suzuki.poulose@arm.com> <1444064531-25607-22-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444064531-25607-22-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2015 at 06:02:10PM +0100, Suzuki K. Poulose wrote: > +static int __init cpuinfo_regs_init(void) > +{ > + int cpu, ret; > + > + for_each_present_cpu(cpu) { > + struct device *dev = get_cpu_device(cpu); > + > + if (!dev) > + return -1; NAK. Go figure out why, I'm too lazy to tell you. > + > + ret = sysfs_create_group(&dev->kobj, &cpuregs_attr_group); > + if (ret) > + return ret; > + } > + > + return 0; > +} > + > +device_initcall(cpuinfo_regs_init); > -- > 1.7.9.5 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.