From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>,
Kyle Walker <kwalker@redhat.com>,
Michal Hocko <mhocko@kernel.org>,
Stanislav Kozina <skozina@redhat.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] mm/oom_kill: change oom_kill_process() to bump ->mm_count rather than ->mm_users
Date: Tue, 6 Oct 2015 18:26:54 +0200 [thread overview]
Message-ID: <20151006162654.GA9570@redhat.com> (raw)
In-Reply-To: <20151005173601.GA23150@redhat.com>
On 10/05, Oleg Nesterov wrote:
>
> Self nack to the changelog ;)
>
> I still think the patch is fine, I'll resend it. But the changelog
> is wrong, in the case above access_process_vm() adds another reference
> to ->mm_users, so mmput() can never lead to mm_users == 0.
Please see v2 with updated changelog I am going to send. However, somehow
I forgot that "mm/oom_kill.c: fix potentially killing unrelated process"
still sits in -mm, so I guess it would be better to fold this change into
mmoom-fix-potentially-killing-unrelated-process.patch.
Oleg.
next prev parent reply other threads:[~2015-10-06 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 16:34 [PATCH -mm] mm/oom_kill: change oom_kill_process() to bump ->mm_count rather than ->mm_users Oleg Nesterov
2015-10-05 17:36 ` Oleg Nesterov
2015-10-06 16:26 ` Oleg Nesterov [this message]
2015-10-06 16:28 ` [PATCH -mm] mmoom-fix-potentially-killing-unrelated-process-fix Oleg Nesterov
2015-10-06 16:56 ` Michal Hocko
2015-10-06 22:49 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006162654.GA9570@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kwalker@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=skozina@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).