From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753775AbbJFRif (ORCPT ); Tue, 6 Oct 2015 13:38:35 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:57638 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753005AbbJFRic (ORCPT ); Tue, 6 Oct 2015 13:38:32 -0400 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 6 Oct 2015 10:38:07 -0700 From: "Paul E. McKenney" To: Josh Triplett Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 0/13] Miscellaneous fixes for 4.4 Message-ID: <20151006173807.GK3910@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20151006161305.GA9799@linux.vnet.ibm.com> <20151006172351.GF9600@cloud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151006172351.GF9600@cloud> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15100617-0009-0000-0000-00000EA12250 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 06, 2015 at 10:23:51AM -0700, Josh Triplett wrote: > On Tue, Oct 06, 2015 at 09:13:05AM -0700, Paul E. McKenney wrote: > > Hello! > > > > This series contains miscellaneous fixes: > > > > 1. Export sched_setscheduler_nocheck() so that the new locktorture > > rtmutex_lock tests can be run as modules, courtesy of Davidlohr > > Bueso. > > > > 2. Use rcu_callback_t in call_rcu*() and friends to improve > > readability and to make cscope able to find them, courtesy of > > Boqun Feng. > > > > 3. Use call_rcu_func_t to replace explicit type equivalents when > > defining RCU callback functions, courtesy of Boqun Feng. > > > > 4. Don't unnecessarily disable preemption for Tiny and Tree > > RCU readers (only for preemptible RCU readers), courtesy > > of Boqun Feng. > > > > 5. Eliminate boot-time panic when a silly boot-time fanout is > > specified. > > > > 6. Add online/offline info to help debug stall-warning messages. > > > > 7. Move preemption disabling out of __srcu_read_lock() into > > srcu_read_lock(). > > > > 8. Finish folding ->fqs_state into ->gp_state, courtesy of Petr Mladek. > > > > 9. Correct comment for values of ->gp_state field. > > > > 10. Add rcu_pointer_handoff() to allow explicit marking of handing > > off protection from RCU to some other means, such as locking > > or reference counting. > > > > 11. Make list_entry_rcu() use lockless_dereference(), courtesy > > of Patrick Marlier. Despite the fact that this patch > > does nothing more than eliminate a single store and a > > single load of an unshared stack variable it nevertheless > > manages to provide a measurable performance increase: > > http://people.csail.mit.edu/amatveev/RLU_SOSP2015.pdf > > > > 12. Remove deprecated rcu_lockdep_assert(). > > (And a patch 13 not mentioned here.) Oops... "Use WRITE_ONCE() when deleting from reader-visible list" included to make KTSAN happier. > I responded to patches 4, 6, and 10 with feedback; for the rest (and for > those with the issues addressed): > > Reviewed-by: Josh Triplett Thank you for the review and comments! Thanx, Paul