From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755367AbbJGRtI (ORCPT ); Wed, 7 Oct 2015 13:49:08 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50553 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754179AbbJGRtG (ORCPT ); Wed, 7 Oct 2015 13:49:06 -0400 Date: Wed, 7 Oct 2015 18:49:04 +0100 From: Maxime Ripard To: Timo Sigurdsson Cc: khilman@kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, wens@csie.org, tyler.baker@linaro.org, olof@lixom.net Subject: Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi Message-ID: <20151007174904.GH2278@lukather> References: <1438532305-5884-1-git-send-email-public_timo.s@silentcreek.de> <20150818153631.GH2547@lukather> <20151005173957.B1BD16C8150E@dd34104.kasserver.com> <7hzizu924y.fsf@deeprootsystems.com> <20151007154918.D6F856C800D4@dd34104.kasserver.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0OWHXb1mYLuhj1Ox" Content-Disposition: inline In-Reply-To: <20151007154918.D6F856C800D4@dd34104.kasserver.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0OWHXb1mYLuhj1Ox Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Timo, On Wed, Oct 07, 2015 at 05:49:18PM +0200, Timo Sigurdsson wrote: > Hi Kevin, > Hi Maxime, >=20 > Kevin Hilman schrieb am 07.10.2015 16:36: >=20 > > "Timo Sigurdsson" writes: > >> I still think that the lower voltages may be the cause of your problem > >> with that specific board, so could you please test the attached patch = on > >> top of my patch that you first experienced the problem with? Please le= t=20 > >> us know whether this solves your issue or whether we need to dig deepe= r. > >=20 > > Thanks for the patch. Looks like it's the OPPs. > >=20 > > I went back to next-20150923 and verified it still fails. Then, I > > applied your patch and saw that it boots just fine. >=20 > Good. Then we can easily fix this, I guess. >=20 > @Maxime: How should we handle this? In its current form, the patch applies > only to the BananaPi dts by overriding the inherited opp from the SoC dts= i. > In an earlier discussion, it was said that this can be done, even though = it > might not be the most elegant approach. But then again, I think it > shouldn't be necessary to change the opp in the sun7i-a20.dtsi for all A20 > boards since this is - to my knowledge - the first and only report that an > A20 board has stability issues at the lower voltages (although not too ma= ny > boards use voltage scaling yet). If you count only the number of boards, indeed, but if you count the number of devices actually used in the field, we cover already a significant portion of them. > So, would you prefer to keep this as a patch for BananaPi only, or > change the dtsi for all A20 devices instead? Yeah, we probably can keep that for bananapi only at the moment, and try to generalize that afterwards. > In case we keep it as it is, what is the correct commit to point to as > "Fixes commit ..."? I'd say it fixes the initial opp commit for A20, since > that's where these voltages were defined. But then again, if we don't > change the dtsi, should I point to my regulator patch instead? I don't think it fixes anything at this point. We droped your commit that was using the A20 OPPs, so in the history so far we don't have anything to fix, just enable cpufreq again. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --0OWHXb1mYLuhj1Ox Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWFVsPAAoJEBx+YmzsjxAgaJIQAK9cqJ/g+dAe/DlIywkJli6v B1OIXSffsP6kfGRWmtAnsFScdXL72Q//NZW6IXGdxzUFIvWhYkRu95eq6OVGmpr4 oY9YNhCFl6WbMlpgJPezGdpc0EJwY0gpfcl1cot1KegydVY23A/Kq/0iMFnuudJK vKifj60eDSPI57PJFasQZOQZ0Jr0ZXF+7Ow19zw8R1pd6cNvJ6RUNNxXW9WQIgnW XVssTTQJP57i+9b/lKaqia30JdYnxdxcak+letCvlVQCZWBSGON6+5Qq+0GMMje5 6n8H5E5lzEPtDA6cqoWKl4pjQOi0ZPV0fPg2qhPO9l3S7bQIyumEV/McAom3D+SA RJ/5bS2fDeLG1aS0yO2/uSm6SOxbDfy28Jc1udeoc7jYJhGg2fuzqf/pMtmvXp2R 7HiiU+CXPjuW+K71ttTXFyDsSWjwUNv8xs6zGGBeWMm0b0BalB/FqztZvIfUwUpf 6LRItlNIL6ChmFryvpsyOTjrcOMS48MCaiqYO2ev1l6dEV3MnW4Ya6ZUWtGblUcB EHr05uqS8Vk+rgNdQzSaDQW5SreA3EzxLezCMm1w3GSlBiJPThX2/WXxkPKbMwr9 sM4exwUWQWfEUTZse91kQXEImkEBPZnSyTeeH1NZEagKhmA/bY0OrNzVPsOrL0WV wx9A8oBLi2iwlfqhjj2X =xA8o -----END PGP SIGNATURE----- --0OWHXb1mYLuhj1Ox--