From: "Timo Sigurdsson" <public_timo.s@silentcreek.de>
To: maxime.ripard@free-electrons.com
Cc: khilman@kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, linux@arm.linux.org.uk,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
wens@csie.org, tyler.baker@linaro.org, olof@lixom.net
Subject: Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi
Date: Wed, 7 Oct 2015 19:58:40 +0200 (CEST) [thread overview]
Message-ID: <20151007175840.A70656C800D4@dd34104.kasserver.com> (raw)
In-Reply-To: <20151007174904.GH2278@lukather>
Hi Maxime,
Maxime Ripard schrieb am 07.10.2015 19:49:
> Hi Timo,
>
> On Wed, Oct 07, 2015 at 05:49:18PM +0200, Timo Sigurdsson wrote:
>> Hi Kevin,
>> Hi Maxime,
>>
>> Kevin Hilman schrieb am 07.10.2015 16:36:
>>
>> > "Timo Sigurdsson" <public_timo.s@silentcreek.de> writes:
>> >> I still think that the lower voltages may be the cause of your problem
>> >> with that specific board, so could you please test the attached patch on
>> >> top of my patch that you first experienced the problem with? Please let
>> >> us know whether this solves your issue or whether we need to dig deeper.
>> >
>> > Thanks for the patch. Looks like it's the OPPs.
>> >
>> > I went back to next-20150923 and verified it still fails. Then, I
>> > applied your patch and saw that it boots just fine.
>>
>> Good. Then we can easily fix this, I guess.
>>
>> @Maxime: How should we handle this? In its current form, the patch applies
>> only to the BananaPi dts by overriding the inherited opp from the SoC dtsi.
>> In an earlier discussion, it was said that this can be done, even though it
>> might not be the most elegant approach. But then again, I think it
>> shouldn't be necessary to change the opp in the sun7i-a20.dtsi for all A20
>> boards since this is - to my knowledge - the first and only report that an
>> A20 board has stability issues at the lower voltages (although not too many
>> boards use voltage scaling yet).
>
> If you count only the number of boards, indeed, but if you count the
> number of devices actually used in the field, we cover already a
> significant portion of them.
>
>> So, would you prefer to keep this as a patch for BananaPi only, or
>> change the dtsi for all A20 devices instead?
>
> Yeah, we probably can keep that for bananapi only at the moment, and
> try to generalize that afterwards.
Ok.
>
>> In case we keep it as it is, what is the correct commit to point to as
>> "Fixes commit ..."? I'd say it fixes the initial opp commit for A20, since
>> that's where these voltages were defined. But then again, if we don't
>> change the dtsi, should I point to my regulator patch instead?
>
> I don't think it fixes anything at this point. We droped your commit
> that was using the A20 OPPs, so in the history so far we don't have
> anything to fix, just enable cpufreq again.
Ok. I'll send a third version of the regulator patch then with the
updated opp included.
Thanks,
Timo
next prev parent reply other threads:[~2015-10-07 17:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 16:18 [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi Timo Sigurdsson
2015-08-03 9:47 ` Maxime Ripard
2015-08-03 13:11 ` [linux-sunxi] " Hans de Goede
2015-08-18 15:33 ` Maxime Ripard
2015-08-04 9:02 ` Timo Sigurdsson
2015-08-18 15:32 ` Maxime Ripard
2015-08-08 15:35 ` [linux-sunxi] " Hans de Goede
2015-08-18 15:36 ` Maxime Ripard
2015-09-24 17:57 ` Kevin Hilman
2015-09-25 15:05 ` Timo Sigurdsson
2015-09-27 8:20 ` Maxime Ripard
2015-10-05 17:39 ` Timo Sigurdsson
2015-10-07 9:44 ` Maxime Ripard
2015-10-07 14:36 ` Kevin Hilman
2015-10-07 15:49 ` Timo Sigurdsson
2015-10-07 17:49 ` Maxime Ripard
2015-10-07 17:58 ` Timo Sigurdsson [this message]
[not found] ` <jwvegh6d60k.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org>
2015-10-08 8:32 ` [linux-sunxi] " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007175840.A70656C800D4@dd34104.kasserver.com \
--to=public_timo.s@silentcreek.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tyler.baker@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).