From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756343AbbJGVFU (ORCPT ); Wed, 7 Oct 2015 17:05:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38983 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754006AbbJGVFT (ORCPT ); Wed, 7 Oct 2015 17:05:19 -0400 Date: Thu, 8 Oct 2015 00:05:11 +0300 From: "Michael S. Tsirkin" To: Avi Kivity Cc: Alex Williamson , Vlad Zolotarov , Greg KH , linux-kernel@vger.kernel.org, hjk@hansjkoch.de, corbet@lwn.net, bruce.richardson@intel.com, avi@cloudius-systems.com, gleb@cloudius-systems.com, stephen@networkplumber.org, alexander.duyck@gmail.com Subject: Re: [PATCH v3 2/3] uio_pci_generic: add MSI/MSI-X support Message-ID: <20151007230553-mutt-send-email-mst@redhat.com> References: <20151005094932.GA5236@kroah.com> <56124EDB.3070701@scylladb.com> <20151006143821.GA11541@redhat.com> <5613DE26.1090202@cloudius-systems.com> <20151006174648-mutt-send-email-mst@redhat.com> <5613E75E.1040002@scylladb.com> <1444157480.4059.67.camel@redhat.com> <5614C11B.6090601@scylladb.com> <1444235464.4059.169.camel@redhat.com> <56154AB4.1050509@scylladb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56154AB4.1050509@scylladb.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2015 at 07:39:16PM +0300, Avi Kivity wrote: > That's what I thought as well, but apparently adding msix support to the > already insecure uio drivers is even worse. I'm glad you finally agree what these drivers are doing is insecure. And basically kernel cares about security, no one wants to maintain insecure stuff. So you guys should think harder whether this code makes any sense upstream. Getting support from kernel is probably the biggest reason to put code upstream, and this driver taints kernel unconditionally so you don't get that. Alternatively, most of the problem you are trying to solve is for virtualization - and it is is better addressed at the hypervisor level. There are enough opensource hypervisors out there - work on IOMMU support there would be time well spent. -- MST