From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754835AbbJHIsc (ORCPT ); Thu, 8 Oct 2015 04:48:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40494 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753960AbbJHIsa (ORCPT ); Thu, 8 Oct 2015 04:48:30 -0400 Date: Thu, 8 Oct 2015 11:48:23 +0300 From: "Michael S. Tsirkin" To: Vlad Zolotarov Cc: Alex Williamson , Avi Kivity , Greg KH , linux-kernel@vger.kernel.org, hjk@hansjkoch.de, corbet@lwn.net, bruce.richardson@intel.com, avi@cloudius-systems.com, gleb@cloudius-systems.com, stephen@networkplumber.org, alexander.duyck@gmail.com Subject: Re: [PATCH v3 2/3] uio_pci_generic: add MSI/MSI-X support Message-ID: <20151008084823.GC19331@redhat.com> References: <20151005031159.GB27303@kroah.com> <56123493.9000602@scylladb.com> <20151005094932.GA5236@kroah.com> <56124EDB.3070701@scylladb.com> <20151006143821.GA11541@redhat.com> <5613DE26.1090202@cloudius-systems.com> <20151006174648-mutt-send-email-mst@redhat.com> <5613E75E.1040002@scylladb.com> <1444157480.4059.67.camel@redhat.com> <5614CFF2.902@cloudius-systems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5614CFF2.902@cloudius-systems.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2015 at 10:55:30AM +0300, Vlad Zolotarov wrote: > * not safe - UIO That's wrong. UIO (in particular uio_pci_generic) can be used safely in many ways, for example with any device not doing DMA. I wouldn't put it upstream otherwise. Make your driver work in such a way that it can be used safely, and it can be merged. But when you try to do this, you will find out just why VFIO/PCI is 1000s of LOC while your patch is only 500. -- MST