From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: "Andre Przywara" <andre.przywara@arm.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Nicolas Ferre" <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Jiri Slaby" <jslaby@suse.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial: atmel: fix compiler warning on address cast
Date: Thu, 8 Oct 2015 10:37:49 +0100 [thread overview]
Message-ID: <20151008093749.GB32532@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20151008090148.GE3485@piout.net>
On Thu, Oct 08, 2015 at 11:01:48AM +0200, Alexandre Belloni wrote:
> On 05/10/2015 at 18:00:52 +0100, Andre Przywara wrote :
> > Turning on KVM and LPAE support on top of a multi_v7_defconfig will
> > produce a compiler warning in the Atmel serial driver:
> > drivers/tty/serial/atmel_serial.c: In function 'atmel_verify_port':
> > drivers/tty/serial/atmel_serial.c:2299:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > if ((void *)port->mapbase != ser->iomem_base)
> > ^
> >
> > Fix that by using the cast on the right hand side instead, as similar
> > code already does in other drivers.
> >
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Hmm, this actually points at a problem, and the cast screems out about it.
Think about it, can you guess what it is?
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-10-08 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 17:00 [PATCH] serial: atmel: fix compiler warning on address cast Andre Przywara
2015-10-08 9:01 ` Alexandre Belloni
2015-10-08 9:37 ` Russell King - ARM Linux [this message]
2015-10-08 10:38 ` Alexandre Belloni
2015-10-08 14:49 ` Andre Przywara
2015-10-08 15:01 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008093749.GB32532@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alexandre.belloni@free-electrons.com \
--cc=andre.przywara@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).