From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932328AbbJHLKH (ORCPT ); Thu, 8 Oct 2015 07:10:07 -0400 Received: from foss.arm.com ([217.140.101.70]:33740 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932268AbbJHLKF (ORCPT ); Thu, 8 Oct 2015 07:10:05 -0400 Date: Thu, 8 Oct 2015 12:10:00 +0100 From: Catalin Marinas To: "Suzuki K. Poulose" Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, Vladimir.Murzin@arm.com, steve.capper@linaro.org, ard.biesheuvel@linaro.org, marc.zyngier@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, edward.nevill@linaro.org, aph@redhat.com, james.morse@arm.com, andre.przywara@arm.com, dave.martin@arm.com Subject: Re: [PATCH v2 14/22] arm64: Cleanup HWCAP handling Message-ID: <20151008111000.GG17192@e104818-lin.cambridge.arm.com> References: <1444064531-25607-1-git-send-email-suzuki.poulose@arm.com> <1444064531-25607-15-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444064531-25607-15-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2015 at 06:02:03PM +0100, Suzuki K. Poulose wrote: > +static bool cpus_have_hwcap(const struct arm64_cpu_capabilities *cap) > +{ > + switch(cap->hwcap_type) { > + case CAP_HWCAP: > + return !!(elf_hwcap & cap->hwcap); > +#ifdef CONFIG_COMPAT > + case CAP_COMPAT_HWCAP: > + return !!(compat_elf_hwcap & (u32)cap->hwcap); > + case CAP_COMPAT_HWCAP2: > + return !!(compat_elf_hwcap2 & (u32)cap->hwcap); > +#endif > + default: > + BUG(); > + return false; > + } > +} Apart from the multiple returns, you don't really need !! since the return type is bool already. -- Catalin