From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758706AbbJIALS (ORCPT ); Thu, 8 Oct 2015 20:11:18 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:40664 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbbJIALR (ORCPT ); Thu, 8 Oct 2015 20:11:17 -0400 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Thu, 8 Oct 2015 17:11:11 -0700 From: "Paul E. McKenney" To: Josh Triplett Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 18/18] rcu: Better hotplug handling for synchronize_sched_expedited() Message-ID: <20151009001111.GN3910@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20151006162907.GA12020@linux.vnet.ibm.com> <1444148977-14108-1-git-send-email-paulmck@linux.vnet.ibm.com> <1444148977-14108-18-git-send-email-paulmck@linux.vnet.ibm.com> <20151007142627.GE3604@twins.programming.kicks-ass.net> <20151007162653.GP3910@linux.vnet.ibm.com> <20151008090128.GI3604@twins.programming.kicks-ass.net> <20151008150639.GA3910@linux.vnet.ibm.com> <20151008151242.GQ3816@twins.programming.kicks-ass.net> <20151008151903.GB3910@linux.vnet.ibm.com> <20151008180114.GA2814@cloud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151008180114.GA2814@cloud> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15100900-0005-0000-0000-000018CEF0C5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2015 at 11:01:14AM -0700, Josh Triplett wrote: > On Thu, Oct 08, 2015 at 08:19:03AM -0700, Paul E. McKenney wrote: > > On Thu, Oct 08, 2015 at 05:12:42PM +0200, Peter Zijlstra wrote: > > > On Thu, Oct 08, 2015 at 08:06:39AM -0700, Paul E. McKenney wrote: > > > > Please see below for the fixed version. Thoughts? > > > > > > > + __releases(rnp->lock) /* But leaves rrupts disabled. */ > > > > + raw_spin_unlock(&rnp->lock); /* rrupts remain disabled. */ > > > > + raw_spin_lock(&rnp->lock); /* rrupts already disabled. */ > > > > > > What them 'rrupts' about? ;-) > > > > Interrupts when it won't fit. I suppose I could use IRQs instead. ;-) > > In this particular case, "IRQs" works just as well; however, in general, > this seems like an excellent example of when to ignore the 80-column > guideline. :) But but but... You are talking to someone who used actual PUNCHED CARDS in real life in a paying job!!! ;-) Thanx, Paul