From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934696AbbJIJ0G (ORCPT ); Fri, 9 Oct 2015 05:26:06 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:36530 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933196AbbJIJ0C (ORCPT ); Fri, 9 Oct 2015 05:26:02 -0400 Date: Fri, 9 Oct 2015 12:25:59 +0300 From: "Kirill A. Shutemov" To: Vineet Gupta Cc: "Kirill A. Shutemov" , Andrew Morton , Andrea Arcangeli , Hugh Dickins , Dave Hansen , Mel Gorman , Rik van Riel , Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Steve Capper , "Aneesh Kumar K.V" , Johannes Weiner , Michal Hocko , Jerome Marchand , Sasha Levin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv12 25/37] mm, thp: remove infrastructure for handling splitting PMDs Message-ID: <20151009092559.GA7346@node> References: <1444145044-72349-1-git-send-email-kirill.shutemov@linux.intel.com> <1444145044-72349-26-git-send-email-kirill.shutemov@linux.intel.com> <56162EC9.8030803@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56162EC9.8030803@synopsys.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2015 at 02:22:25PM +0530, Vineet Gupta wrote: > On Tuesday 06 October 2015 08:53 PM, Kirill A. Shutemov wrote: > > With new refcounting we don't need to mark PMDs splitting. Let's drop code > > to handle this. > > > .... > > > > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > > index 29c57b2cb344..010a7e3f6ad1 100644 > > --- a/include/asm-generic/pgtable.h > > +++ b/include/asm-generic/pgtable.h > > @@ -184,11 +184,6 @@ static inline void pmdp_set_wrprotect(struct mm_struct *mm, > > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > #endif > > > > -#ifndef __HAVE_ARCH_PMDP_SPLITTING_FLUSH > > -extern void pmdp_splitting_flush(struct vm_area_struct *vma, > > - unsigned long address, pmd_t *pmdp); > > -#endif > > > Hi Kirill, > > While at it - you would also want to nuke > > Documentation/features/vm/pmdp_splitting_flush/ Sure. The patch below can be folded into this one. diff --git a/Documentation/features/vm/pmdp_splitting_flush/arch-support.txt b/Documentation/features/vm/pmdp_splitting_flush/arch-support.txt deleted file mode 100644 index 26f74b457e0b..000000000000 --- a/Documentation/features/vm/pmdp_splitting_flush/arch-support.txt +++ /dev/null @@ -1,40 +0,0 @@ -# -# Feature name: pmdp_splitting_flush -# Kconfig: __HAVE_ARCH_PMDP_SPLITTING_FLUSH -# description: arch supports the pmdp_splitting_flush() VM API -# - ----------------------- - | arch |status| - ----------------------- - | alpha: | TODO | - | arc: | TODO | - | arm: | ok | - | arm64: | ok | - | avr32: | TODO | - | blackfin: | TODO | - | c6x: | TODO | - | cris: | TODO | - | frv: | TODO | - | h8300: | TODO | - | hexagon: | TODO | - | ia64: | TODO | - | m32r: | TODO | - | m68k: | TODO | - | metag: | TODO | - | microblaze: | TODO | - | mips: | ok | - | mn10300: | TODO | - | nios2: | TODO | - | openrisc: | TODO | - | parisc: | TODO | - | powerpc: | ok | - | s390: | ok | - | score: | TODO | - | sh: | TODO | - | sparc: | TODO | - | tile: | TODO | - | um: | TODO | - | unicore32: | TODO | - | x86: | ok | - | xtensa: | TODO | - ----------------------- -- Kirill A. Shutemov