From: Matt Fleming <matt@console-pimps.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ong Boon Leong <boon.leong.ong@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-efi@vger.kernel.org,
Sam Protsenko <semen.protsenko@linaro.org>,
Peter Jones <pjones@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
Roy Franz <roy.franz@linaro.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Fleming Matt <matt.fleming@intel.com>
Subject: Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol
Date: Sat, 10 Oct 2015 23:02:02 +0100 [thread overview]
Message-ID: <20151010220202.GH2723@codeblueprint.co.uk> (raw)
In-Reply-To: <20151005131350.GA26329@nazgul.tnic>
On Mon, 05 Oct, at 03:13:50PM, Borislav Petkov wrote:
> On Tue, Oct 06, 2015 at 04:15:54AM +0800, Kweh, Hock Leong wrote:
> > From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
> >
> > This patch export efi_capsule_supported() function symbol for capsule
> > kernel module to use.
> >
> > Cc: Matt Fleming <matt.fleming@intel.com>
> > Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>
> > ---
> > drivers/firmware/efi/capsule.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/firmware/efi/capsule.c b/drivers/firmware/efi/capsule.c
> > index d8cd75c0..738d437 100644
> > --- a/drivers/firmware/efi/capsule.c
> > +++ b/drivers/firmware/efi/capsule.c
> > @@ -101,6 +101,7 @@ out:
> > kfree(capsule);
> > return rv;
> > }
> > +EXPORT_SYMBOL_GPL(efi_capsule_supported);
>
> So this one is still a separate patch.
>
> If you're going to ignore review comments, maybe I should stop wasting
> my time reviewing your stuff...
I agree that it makes sense to fold this patch into your PATCH 2,
because then we know why we need the above symbol to be exported.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-10-10 22:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 20:15 [PATCH v7 0/2] Enable capsule loader interface for efi firmware updating Kweh, Hock Leong
2015-10-05 20:15 ` [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol Kweh, Hock Leong
2015-10-05 13:13 ` Borislav Petkov
2015-10-05 15:19 ` Kweh, Hock Leong
2015-10-05 21:27 ` Bryan O'Donoghue
2015-10-06 10:53 ` Kweh, Hock Leong
2015-10-06 14:53 ` Bryan O'Donoghue
2015-10-07 2:01 ` Kweh, Hock Leong
2015-10-07 8:27 ` Bryan O'Donoghue
2015-10-10 22:02 ` Matt Fleming [this message]
2015-10-11 14:28 ` Kweh, Hock Leong
2015-10-11 19:03 ` Matt Fleming
2015-10-05 20:15 ` [PATCH v7 2/2] efi: a misc char interface for user to update efi firmware Kweh, Hock Leong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151010220202.GH2723@codeblueprint.co.uk \
--to=matt@console-pimps.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=boon.leong.ong@intel.com \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=hock.leong.kweh@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=matt.fleming@intel.com \
--cc=pjones@redhat.com \
--cc=roy.franz@linaro.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).