From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752613AbbJNA4j (ORCPT ); Tue, 13 Oct 2015 20:56:39 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:21443 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752156AbbJNA4h (ORCPT ); Tue, 13 Oct 2015 20:56:37 -0400 X-Greylist: delayed 466 seconds by postgrey-1.27 at vger.kernel.org; Tue, 13 Oct 2015 20:56:37 EDT Date: Tue, 13 Oct 2015 20:48:42 -0400 From: Steven Rostedt To: Dmitry Safonov <0x7f454c46@gmail.com> Cc: mingo@redhat.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] ftrace: remove redundant strsep in mod_callback Message-ID: <20151013204842.4d43cdfb@grimm.local.home> In-Reply-To: <1443545176-3215-1-git-send-email-0x7f454c46@gmail.com> References: <1443545176-3215-1-git-send-email-0x7f454c46@gmail.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2015 19:46:12 +0300 Dmitry Safonov <0x7f454c46@gmail.com> wrote: > - ret = ftrace_match_module_records(hash, func, mod); > - if (!ret) > - ret = -EINVAL; > + ret = ftrace_match_module_records(hash, func, param); > + if (ret == 0) Small nit, personally, I prefer the if (!ret) version. For me "== 0" is for counters and strcmp. I may change this to be consistent with the rest of the code. -- Steve > + return -EINVAL; > if (ret < 0) > return ret; >