Re: [PATCH 21/31] perf test: Enforce LLVM test, add kbuild test

[Arnaldo Carvalho de Melo <acme@redhat.com>]

Em Mon, Oct 19, 2015 at 11:42:31PM +0900, Namhyung Kim escreveu:
> Hi,
> 
> On Wed, Oct 14, 2015 at 12:41:32PM +0000, Wang Nan wrote:
> > This patch enforces existing LLVM test, makes it compile more than one
> > BPF source file. The compiled results are stored, can be used for other
> > testcases. Except the first testcase (named LLVM_TESTCASE_BASE), failures
> > of other test cases are not considered as failure of the whole test.
> > 
> > Adds a kbuild testcase to check whether kernel headers can be correctly
> > found.
> > 
> > For example:
> > 
> >  # perf test LLVM
> > 
> >    38: Test LLVM searching and compiling                        : (llvm.kbuild-dir can be fixed) Ok
> 
> IMHO it'd be better to keep the test result simply as either "Ok" or
> "FAILED" and provide details with -v option.

"Skipped" looks more natural here, with the reason for it skipping being shown
only with -v.

Ingo made some comments about 'perf test' output recently, have you read that?

> Anyway I found the tracepoint error message is annoying in the current

You mean all these warnings:

[root@zoo ~]# perf test "parse event" 
 5: parse events tests                                       :  Warning: [sunrpc:xprt_lookup_rqst] function __builtin_constant_p not defined
  Warning: [sunrpc:xprt_transmit] function __builtin_constant_p not defined
  Warning: [sunrpc:xprt_complete_rqst] function __builtin_constant_p not defined
<SNIP>
  Warning: [xen:xen_mmu_set_pud] function sizeof not defined
  Warning: [xen:xen_mmu_set_pgd] function sizeof not defined
  Warning: [xen:xen_mmu_ptep_modify_prot_start] function sizeof not defined
  Warning: [xen:xen_mmu_ptep_modify_prot_commit] function sizeof not defined
 Ok
[root@zoo ~]# 

i.e. making those warnings appear only under 'perf test -v'? Cool!

> perf test output.  Will send a fix soon.
> 
> Thanks,
> Namhyung