From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752751AbbJTNHG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 20 Oct 2015 09:07:06 -0400
Received: from casper.infradead.org ([85.118.1.10]:56139 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752546AbbJTNHA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 20 Oct 2015 09:07:00 -0400
Date: Tue, 20 Oct 2015 10:06:51 -0300
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Chandler Carruth <chandlerc@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>, Borislav Petkov <bp@suse.de>,
        David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 13/16] perf callchain: Switch default to
 'graph,0.5,caller'
Message-ID: <20151020130651.GC5119@kernel.org>
References: <1444079018-31421-1-git-send-email-acme@kernel.org>
 <1444079018-31421-14-git-send-email-acme@kernel.org>
 <CAE40pdfrVsENQeGWqDHS0HP_6S4BBNtp7cYVgjOw2zUNL--1EQ@mail.gmail.com>
 <20151009215626.GM14409@kernel.org>
 <CAE40pddVCjHVC4nD=xBcMmE6dy+xPe2rVgK8a1QM9sv0zZWEgw@mail.gmail.com>
 <20151009222504.GN14409@kernel.org>
 <CAE40pde1c3UVDWD5Gw85w9CxwPDzf9DiN=px=c0SbHS8=Bwuzw@mail.gmail.com>
 <20151020120033.GB5119@kernel.org>
 <20151020121948.GA29289@lerouge>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151020121948.GA29289@lerouge>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Oct 20, 2015 at 02:19:50PM +0200, Frederic Weisbecker escreveu:
> On Tue, Oct 20, 2015 at 09:00:34AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Oct 19, 2015 at 05:16:53PM -0700, Brendan Gregg escreveu:
> > So are you advocating different defaults, one for --stdio (callee),
> > another for --tui, --gtk (caller)?

> > This is all configurable via ~/.perfconfig :-\

> > Indeed, finding a default that is deemed adequate for most people is,
> > ho-hum, difficult 8-)
 
> Most uses I've seen on LKML by the past involved callee because people
> mostly look at the precise point where a performance issue is.

A good chunk of that was because that was the default? 
 
> IMHO changing that order is not a good idea. Unless many users complained
> about it.

Perhaps there are not that many users of callchains because the default
is not what they're used to see?

Motivation for the change came from a video from Chandler, that
resurfaced the callchain default issue, Chandler?

Anedoctally, he tweeted about it and people seemed to like it.
 
> > Ingo, what do you think?

What about providing a hotkey, in the tui, to toggle caller/callee
views, and another hotkey to save that in ~/.perfconfig so that becomes
the new default?

In the --stdio mode we need to add a warning in the first lines,
something like:

# This is caller (or callee) based, please use --callchain ... to change it

One way or the other people will disagree, so making it easy to switch
to the preferred way would be nice to have?

- Arnaldo