From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753518AbbJUG3o (ORCPT ); Wed, 21 Oct 2015 02:29:44 -0400 Received: from mail-bn1bon0087.outbound.protection.outlook.com ([157.56.111.87]:49067 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752267AbbJUG3l (ORCPT ); Wed, 21 Oct 2015 02:29:41 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; 01.org; dkim=none (message not signed) header.d=none;01.org; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NWK4PC-07-7NG-02 X-M-MSG: Date: Wed, 21 Oct 2015 14:28:41 +0800 From: Huang Rui To: Jean Delvare CC: Guenter Roeck , kbuild test robot , Yuanhan Liu , Fengguang Wu , , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , Andreas Herrmann , Thomas Gleixner , Ingo Molnar , "Rafael J. Wysocki" , Len Brown , John Stultz , Frederic Weisbecker , , , , Andreas Herrmann , Aravind Gopalakrishnan , Borislav Petkov , Aaron Lu , Tony Li Subject: Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power Message-ID: <20151021062841.GB30332@hr-amur2> References: <1445308109-17970-6-git-send-email-ray.huang@amd.com> <201510201509.U8tGXwCz%fengguang.wu@intel.com> <20151021014214.GA26968@hr-amur2> <5626F53D.2090009@roeck-us.net> <20151021024002.GB26968@hr-amur2> <5626FD51.4090402@roeck-us.net> <20151021030400.GC26968@hr-amur2> <20151021080520.30f28ce9@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20151021080520.30f28ce9@endymion.delvare> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(24454002)(479174004)(164054003)(377454003)(199003)(189002)(101416001)(105586002)(76176999)(50466002)(92566002)(64706001)(54356999)(5008740100001)(50986999)(106466001)(46102003)(86362001)(46406003)(23726002)(5007970100001)(5001920100001)(11100500001)(33716001)(97736004)(47776003)(110136002)(97756001)(33656002)(4001350100001)(189998001)(93886004)(83506001)(87936001)(77096005)(2950100001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR12MB0859;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0859;2:CW/1nCHEisH8lYxPcPIce4nwQN2O2MM2mbe3PdE5dasNQZOh1JBtVGR3sBSjYFssZA6OFzuImC3EP1S+TYaFJXTAPmBx2eRmBZOOUh8U9+ak+xgX2u7GlSPUyMG1TtFI/Byu/+KFy3KwHz3e6vM3xkb+76mVXNg8Es0kgt+hS+4=;3:wVYr1bFJjqBFeWY0ZO2gbDwPo0Q79nVedQ2z/qSEu0Yo6JW4qW52PVaJuJRXzbg1shEKWuvShzUIz/1TUFiNB5c2cZ7tUUVjedM+H5oiFBqAiKIl2nWuR7YoK3W9QBWItd4ajIf7ekMZTHYtozEmB+QMwAEM5RDS776GIl9OIX25x2NHFKpKUSbOB6UgOI++HOo80/w7E//QD5VEyaWD826VPlDDdwY8hsSQONvZF30DaoUk0PBWU3CMYQHyOROn;25:1FbvLc8+MkVoPbDhljt3L55gEe+ECyfWuur4tdpWU8l/gWcMKrcsmCpVljCwO8KBQaZ/lV1urJeSkK3fK1p24PP2ysKFJRs12+SdfgHpixTzSByC+1qjrDGCE1FQ4EgWmr7k7w28EAAgHmnZGy62YJv0zwVRr199joCL58O5gP5WAbw/e8ZEwoni8kZuc7TOo+ADypAEHCp96qjPdNw2+x/KC4PbmjtqRcovmc7dvMUtuFMoqr+tv+SNwPoZcHfasoQjU4OqM2e0P3iiqF+2pQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR12MB0859; X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0859;20:lVoiTQid6+S2i5aeBkG3fGnDnLrvZtBW15DLmNeCFswXBiKSUVqPmQ2qcTQAn5uzUswsP7O3Mjjw+yKv9mvDGmobRvqBD3Ozt7/XkOpNwVI57T8NM/DPa+/CCkUAeu9o3SnzrjZ8bS7LLKYjLjMgmmwotlaokuCx8OeoIiTbf2nw33fD2JOVtqnYQA35d1PfIaLPDyCgGZIWN+Y7+SUvP7s/E+1Qgh4EnHgEKrXCIsZOk8tbXtcIoSikVJ1YTIaWXI61o651ndaaJ3Nz7sxdSeA9/lld8/agvuOEsDuwCrhJTKhZLktrevjbaTwYecHgrOT0xTVhed+uiGvRbNBREunVEV/Lyba59zR3si9K6dKAWcMCUeqdSiVfQb7n3H9tB1syDq/5t9w8ZwJnPqAYGwLx28rChqvyI85AgVVi++PRxjvZYfdRRhudSu8GoglVyW573qABmPyE7LS4qZSTqN99uw/4gRravoSMuh3aU68+3o00Ahqav2Yhikz4OC5I;4:X0qrio6A+Beve5m0SwUePnLq3xhQ2EKqZhMIorhJFXk4G58qsEa181SHBicGg7DEu+Cu4pvw5doWKoJhgSlgzpTidzp2Z3WhsSSejad1SPRr4gjKZwNfmFZamlNfhgHKKkX80gSP364cRX4nz4uXFnCZbvohpudV/WX4lZ9dAunsY+quwy5IG+2g/uFzvoPwZLEeCzf9YN3jPLrkwCnsXe0DIU6WVA67YM7vhTQC1LeB1zYwU95aiGeB0+rl/m7UNswVHBz/U+WgcVHkVKT6QadHhuiPqYflDcW3X0qIvcYXMqcSh22N7z/DO+6nhfcxGM9vkyz9D19PSRZ8C6F4nFcgLlPcwC7tORpfe4VIf5k= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:DM3PR12MB0859;BCL:0;PCL:0;RULEID:;SRVR:DM3PR12MB0859; X-Forefront-PRVS: 073631BD3D X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR12MB0859;23:LH0PzWKR6wfDOF86x3gw4xo2tN7z9eKpwOxsMS+2b?= =?us-ascii?Q?CxLfXs46XIZq422V0lI4Q6Pf3nFHavEc0Qm+GLHTGbUl19w2320GQspv1GZv?= =?us-ascii?Q?yROpsXFSTqG7OyRm0ly70vbXDE/3kbRDCZojFrIEvv7OLjbjNWpBouNFZcaY?= =?us-ascii?Q?N/x5UQ7rhdCJqlsS9r+ruHAGpcKFEMf9hftSWK+NPNU5aBv9LcKd+mfJ5MTw?= =?us-ascii?Q?j0eYLWQ+NdoaHxC7Zk6DqhgzK3ewRmGTy/XvJB2+UwTUNJkdzH8JizufAw/T?= =?us-ascii?Q?LDs+sgG2aVqmMo87AufHU94cItT2vvWLFk1drWSnm9HF/XKhNecZFludIIQa?= =?us-ascii?Q?ehBaSvxHcF3l+a8V9UMcyqBabXpPqc/0Gjr7tJiegCpc3CF1e+ZKz+DdXL+O?= =?us-ascii?Q?fFKLatC6flQs014mnaB15KqILsYm+U59A7U+in2LwGJRK4KvDc2KIvH5DPjg?= =?us-ascii?Q?DaG7NVzx66g5G7wSIbFUyRaCELA0WwwvD3UhRP7wlpTvzDkTGlrT1FFEJggn?= =?us-ascii?Q?5KUK6LikwdSYr4rPG9oQwrKjhu+3xZ/21IHjV/tg8YlhUD5X7GltFQPXB0Vr?= =?us-ascii?Q?1Aoed6AIf3JqW2345aUjLB9rWDHZY+I7N8uFuS3B/JqXbjanE6v+Y7jmY8sx?= =?us-ascii?Q?tkz3nvr3Hv6SmaohE4LP/x9UKAmoyyM8+cBbMc8+vyIXYB7AyNz652VrCOFw?= =?us-ascii?Q?M/Zg+mrvNt1gTbXWpUgLsduqJiR0WBGvlwYkHP9ACdY/G4L2jcDEsMJFZLaX?= =?us-ascii?Q?+4bd3AzOm9urax3jIjiZYhB7sFh/y/AoVt3iq8hN/YNeRwlshdLjvdMai3uM?= =?us-ascii?Q?uDncsYPRen8hq61xgjZrWd3iUOZI/HTmtJLuDeAJkqSAqux3cEc+L2WmLFhz?= =?us-ascii?Q?ZcBvsNzVazUqolAhJVfk2+9gcsW181ULCOeEPiMY9PNQxTnnkWozVmtr5ruf?= =?us-ascii?Q?0DO7PP3QwT98aLQMtgiRoa1uWrxJ6qneuTaR7IRbISgehzbVUxoUD4xEM8Lh?= =?us-ascii?Q?VZJY0ghvU1qZV6GEZ4DdNlDiqeMEKlKyU8Wnb1ZHq+4uW73b4xc5jyqSg+vb?= =?us-ascii?Q?2Q5NCQaXatsweypgP6K9Ob1tdi/?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0859;5:T8nb2FeAAznnTncsyYftzJU5JU3mCBCzU3wtZTKBGkk73BtYj1jc2+W3zEShJnx4mZaMrKllB2tN7UuW8sQKi4Ikt2jmAkZfVxJdhGxKeaWBovR3s0hDfBX2wUs6hvYrwttp+IKZfv7RdXdH/Yr5dA==;24:e5i+EsWNivFaUNhOnOoXQp3T9Rc95Dp+8IjeWVWmViieDMNiLOjJGL1ARijvvvwg4YJEm78wjoG55AOO4yHuLsBL9TfSrmOrWmtQ12IVTKA=;20:uk2yh9JPKHXgspdSIfmWx4oo0T0jnXVaJBoY310Fd3yPE2fE9jS1FpJLQShgbh45zWUYMtm+0P0rA1A1+60IbZ9MLQFKPC8ZFZbOiJ6k2PVtBWBOq2NOv6LzCq7MhN1NOv70pMnZi7cHxyNbJFT1xa3fCJMId2OlhnUvNe1iUbbjbc244KEdXkEJowkTqghpXw88MQTc6w4zhW5jRzRGFjvuwY5oduVzTRfvq4psyIzpMx1YTRCi0MQJd04hRQme SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2015 06:29:37.2933 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR12MB0859 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jean, On Wed, Oct 21, 2015 at 08:05:20AM +0200, Jean Delvare wrote: > Hi Rui, > > On Wed, 21 Oct 2015 11:04:01 +0800, Huang Rui wrote: > > On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote: > > > On 10/20/2015 07:40 PM, Huang Rui wrote: > > > >>>Thanks to report this issue. :) > > > >>>The root cause is that the test config doesn't enable > > > >>>CONFIG_CPU_SUP_AMD. > > > >>> > > > >>>How about below fix: > > > >>> > > > >> > > > >>Guess you don't have a choice. > > > >> > > > > > > > >Yes, if I use test config, fam15h_power isn't chosen. :) > > > > > > > >And if I use the "select" flag like below, fam15h_power can be built > > > >successfully. > > > > > > > That is another possibility, though that isn't how CPU_SUP_AMD > > > is handled by its other users. Matter of philosophy, I guess. > > > > Err, sorry. Could you please point out the other possibility? > > Both possibilities came from you. First one is to use "depends", second > one is to use "select". > > As pointed out bu Gunter, other drivers (EDAC_DECODE_MCE, MICROCODE, > AMD_NB) use "depends" so you should do the same for consistency. > Thanks to clarify it. I will use "depends" at next version. Thanks, Rui