From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753402AbbJUH3M (ORCPT <rfc822;w@1wt.eu>);
	Wed, 21 Oct 2015 03:29:12 -0400
Received: from mail-pa0-f41.google.com ([209.85.220.41]:34386 "EHLO
	mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752035AbbJUH3K (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 21 Oct 2015 03:29:10 -0400
Date: Wed, 21 Oct 2015 16:29:02 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>, Borislav Petkov <bp@suse.de>,
        Chandler Carruth <chandlerc@gmail.com>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 13/16] perf callchain: Switch default to
 'graph,0.5,caller'
Message-ID: <20151021072902.GH628@sejong>
References: <1444079018-31421-1-git-send-email-acme@kernel.org>
 <1444079018-31421-14-git-send-email-acme@kernel.org>
 <20151013042643.GA9571@sejong>
 <CAE40pdfJVcjkYvizxXVWTxTvYYh3brhxNry4Dch93tB2j-C0FQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAE40pdfJVcjkYvizxXVWTxTvYYh3brhxNry4Dch93tB2j-C0FQ@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Brendan,

On Mon, Oct 19, 2015 at 04:50:11PM -0700, Brendan Gregg wrote:
> On Mon, Oct 12, 2015 at 9:26 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> > On Mon, Oct 05, 2015 at 06:03:35PM -0300, Arnaldo Carvalho de Melo wrote:
> >> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> >>
> >> Which is the most common default found in other similar tools.
> >
> > I think it's more useful to change the default only when --children is
> > used.  And there's a related issue too - please see below link:
> >
> >   https://lkml.org/lkml/2014/8/14/49
> 
> --children is default for things like "perf report --stdio" and
> (implied) "perf script", so any change to --children is a change to
> default.

Hmm.. right.  It should change the default only when --children is
actually used in "perf report" or "perf top" so that "perf script" or
other commands should not be changed.

Thanks,
Namhyung