From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757208AbbJVKdt (ORCPT ); Thu, 22 Oct 2015 06:33:49 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:38758 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757151AbbJVKdr (ORCPT ); Thu, 22 Oct 2015 06:33:47 -0400 Date: Thu, 22 Oct 2015 12:33:44 +0200 From: Artem Savkov To: "Kirill A. Shutemov" Cc: "Kirill A. Shutemov" , Andrew Morton , Andrea Arcangeli , Hugh Dickins , Dave Hansen , Mel Gorman , Rik van Riel , Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Steve Capper , "Aneesh Kumar K.V" , Johannes Weiner , Michal Hocko , Jerome Marchand , Sasha Levin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv12 14/37] futex, thp: remove special case for THP in get_futex_key Message-ID: <20151022103344.GB29487@littlebeast.usersys.redhat.com> References: <1444145044-72349-1-git-send-email-kirill.shutemov@linux.intel.com> <1444145044-72349-15-git-send-email-kirill.shutemov@linux.intel.com> <20151022082433.GA29487@littlebeast.usersys.redhat.com> <20151022094945.GE10597@node.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151022094945.GE10597@node.shutemov.name> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 22, 2015 at 12:49:45PM +0300, Kirill A. Shutemov wrote: > On Thu, Oct 22, 2015 at 10:24:33AM +0200, Artem Savkov wrote: > > On Tue, Oct 06, 2015 at 06:23:41PM +0300, Kirill A. Shutemov wrote: > > > With new THP refcounting, we don't need tricks to stabilize huge page. > > > If we've got reference to tail page, it can't split under us. > > > > > > This patch effectively reverts a5b338f2b0b1. > > > > > > Signed-off-by: Kirill A. Shutemov > > > Tested-by: Sasha Levin > > > Tested-by: Aneesh Kumar K.V > > > Acked-by: Jerome Marchand > > > --- > > > kernel/futex.c | 61 ++++++++++++---------------------------------------------- > > > 1 file changed, 12 insertions(+), 49 deletions(-) > > > > This patch breaks compound page futexes with the following panic: > > Thanks for report. Patch below fixes the issue for me. > Could you test it as well? > Yep, this patch does fix the problem for me as well. -- Regards, Artem